Add PiecewiseSequence take microbenchmarks#8830
Draft
danking wants to merge 2 commits into
Draft
Conversation
danking
force-pushed
the
codex/piecewise-sequence-benchmarks
branch
from
July 17, 2026 19:12
18df62f to
04a21ec
Compare
danking
force-pushed
the
codex/piecewise-sequential-run-take-consumers
branch
from
July 17, 2026 19:40
9adf56d to
c4a0358
Compare
danking
force-pushed
the
codex/piecewise-sequence-benchmarks
branch
from
July 17, 2026 19:40
0906157 to
f5c8555
Compare
danking
force-pushed
the
codex/piecewise-sequential-run-take-consumers
branch
2 times, most recently
from
July 17, 2026 20:19
80f7b89 to
30870aa
Compare
danking
force-pushed
the
codex/piecewise-sequential-run-take-consumers
branch
from
July 17, 2026 20:25
30870aa to
e777ab4
Compare
danking
force-pushed
the
codex/piecewise-sequence-benchmarks
branch
from
July 17, 2026 20:33
f5c8555 to
b59c45f
Compare
danking
force-pushed
the
codex/piecewise-sequential-run-take-consumers
branch
from
July 17, 2026 20:37
e777ab4 to
e4a0543
Compare
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
danking
force-pushed
the
codex/piecewise-sequence-benchmarks
branch
from
July 17, 2026 20:41
b59c45f to
388d234
Compare
Contributor
|
I think we want benchmarks. I came up with the long term solution in #8825 and we have to make sure we don't regress |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@robert3005 I'm not sure if you want to check these in. These are what I used to reason about various ways to copy slices of data from one spot in memory to another.
Summary
piecewise_sequence_take_primitiveto compare constant-length PiecewiseSequence take against dense lengths and reifying constant lengthstake_slices_to_buffer_matrixto compare extend/cursor-copy loops with and without preverification plus unchecked slicingValidation
cargo +nightly fmt --allcargo clippy -p vortex-array --all-targets --all-features -- -D warningscargo bench -p vortex-array --bench piecewise_sequence_take_primitivecargo bench -p vortex-array --bench take_slices_to_buffer_matrix