DO NOT MERGE Combine PiecewiseSequence take stack#8837
Conversation
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
Signed-off-by: Daniel King <dan@spiraldb.com>
…copy' into codex/piecewise-sequence-combined-pr Signed-off-by: Daniel King <dan@spiraldb.com>
…ts' into codex/piecewise-sequence-combined-pr Signed-off-by: Daniel King <dan@spiraldb.com>
Merging this PR will regress 1 benchmark
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | varbinview_large |
389.9 µs | 446.4 µs | -12.66% |
| ⚡ | Simulation | struct_large |
432.6 µs | 38 µs | ×11 |
| ⚡ | Simulation | fsl_large |
616.5 µs | 87.8 µs | ×7 |
| ⚡ | Simulation | take_fsl_random[1024, 1000] |
15.2 ms | 6 ms | ×2.5 |
| ⚡ | Simulation | take_fsl_nullable_random[1024, 1000] |
14.8 ms | 6 ms | ×2.5 |
| ⚡ | Simulation | take_fsl_random[256, 1000] |
3.5 ms | 1.6 ms | ×2.2 |
| ⚡ | Simulation | take_fsl_nullable_random[256, 1000] |
3.4 ms | 1.6 ms | ×2.1 |
| ⚡ | Simulation | take_fsl_random[1024, 100] |
1,568.1 µs | 798 µs | +96.51% |
| ⚡ | Simulation | take_fsl_nullable_random[1024, 100] |
1,535.9 µs | 808.3 µs | +90.02% |
| ⚡ | Simulation | take_fsl_random[256, 100] |
418.5 µs | 237.7 µs | +76.06% |
| ⚡ | Simulation | take_fsl_random[64, 1000] |
815.7 µs | 468.1 µs | +74.28% |
| ⚡ | Simulation | take_fsl_nullable_random[64, 1000] |
812 µs | 482.8 µs | +68.19% |
| ⚡ | Simulation | take_fsl_nullable_random[256, 100] |
415.8 µs | 247.9 µs | +67.73% |
| ⚡ | Simulation | list_i32_large |
172.3 µs | 106.2 µs | +62.22% |
| ⚡ | Simulation | take_fsl_random[16, 1000] |
237.9 µs | 182.4 µs | +30.43% |
| ⚡ | Simulation | take_filter_list_slice_mask_random_indices[256, 50] |
118.4 µs | 93.2 µs | +27.06% |
| ⚡ | Simulation | take_filter_list_small_uncached_random_mask_random_indices[256, 10] |
116.1 µs | 91.6 µs | +26.82% |
| ⚡ | Simulation | take_filter_list_nullable_random_mask_random_indices[256, 50] |
128.4 µs | 101.3 µs | +26.78% |
| ⚡ | Simulation | take_filter_list_small_random_mask_random_indices[256, 10] |
115.4 µs | 91.1 µs | +26.69% |
| ⚡ | Simulation | take_filter_list_slice_mask_random_indices[768, 50] |
118.6 µs | 93.9 µs | +26.3% |
| ... | ... | ... | ... | ... | ... |
ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing codex/piecewise-sequence-combined-pr (012f18f) with develop (e6eeaae)
Footnotes
-
53 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Polar Signals Profiling ResultsLatest Run
Powered by Polar Signals Cloud |
Benchmarks: Vortex queries 📖Verdict: No clear signal (medium confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.855x ✅, 2↑ 0↓)
datafusion / parquet (0.830x ✅, 2↑ 0↓)
duckdb / vortex-file-compressed (1.013x ➖, 0↑ 0↓)
duckdb / parquet (0.958x ➖, 0↑ 0↓)
No file size changes detected. |
Summary
Combines the non-benchmark PiecewiseSequence take stack into one PR:
Excludes the benchmark-only PR #8830.
Validation
origin/developusingcargo codspeed build/run -m walltime.take_fslandlistview_rebuild.