fix(mcp): allow clear_index to drop orphaned collections without local path#387
Open
MukundaKatta wants to merge 1 commit into
Open
fix(mcp): allow clear_index to drop orphaned collections without local path#387MukundaKatta wants to merge 1 commit into
MukundaKatta wants to merge 1 commit into
Conversation
…l path clear_index validated that the codebase path exists on disk before dropping its Milvus collection. The local folder is only used as the collection identifier, so a moved or deleted directory left the collection orphaned with no way to clear it. Drop the fs existence and directory checks; the isIndexed/isIndexing check already proves there is a collection to remove. Fixes zilliztech#375
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
clear_indexvalidated that the codebase path exists on disk before dropping its Milvus collection:But the path is only used as the collection identifier. If a codebase is moved or deleted on disk, its collection is left orphaned with no way to clear it, since the existence check fails before any Milvus call runs.
Change
Remove the
fs.existsSyncandfs.statSyncdirectory checks fromhandleClearIndex. The existingisIndexed/isIndexingcheck already proves there is a collection to drop, and the path serves only as the key. Index and search handlers, which genuinely need a local directory, are untouched.Testing
tsc --noEmitclean for the mcp packagepnpm --filter @zilliz/claude-context-mcp testpasses (4/4)Fixes #375