fix(mcp): derive default version from package metadata#385
Open
wuyua9 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/mcp/package.jsoninstead of the stale hard-coded1.0.0MCP_SERVER_VERSIONenvironment overrideWhy
createMcpConfig()passesconfig.versioninto the MCP server metadata. The package is currently versioned as0.1.13, but a default install still reports1.0.0unlessMCP_SERVER_VERSIONis set.Tests
./node_modules/.bin/tsc --build packages/core --forcecd packages/mcp && node --import tsx --test "src/config.test.ts"./node_modules/.bin/tsc --build packages/mcp --forcegit diff --checkNote:
pnpm --filter @zilliz/claude-context-mcp test -- --test-name-pattern 'server version'attempted to run through the local pnpm shim, but pnpm 11 aborted withERR_PNPM_ABORTED_REMOVE_MODULES_DIR_NO_TTYbefore executing tests, so I used the package's underlyingnode --import tsx --testcommand directly.