Security: Sensitive API tokens stored in chrome.storage.sync#341
Open
tuanaiseo wants to merge 1 commit into
Open
Conversation
…me.storage.syn The extension saves high-value secrets (GitHub token, OpenAI token, Milvus credentials) in `chrome.storage.sync`. Sync storage propagates data across signed-in browser profiles/devices and increases exposure if a synced account/session is compromised. Affected files: milvusConfig.ts Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The extension saves high-value secrets (GitHub token, OpenAI token, Milvus credentials) in
chrome.storage.sync. Sync storage propagates data across signed-in browser profiles/devices and increases exposure if a synced account/session is compromised.Severity:
highFile:
packages/chrome-extension/src/config/milvusConfig.tsSolution
Do not store API secrets in
chrome.storage.sync. Preferchrome.storage.localwith minimal retention, or use short-lived tokens/OAuth flows. Consider encrypting at rest with a user-provided passphrase and avoid auto-syncing secrets across devices.Changes
packages/chrome-extension/src/config/milvusConfig.ts(modified)Testing