Remove code review failure telemetry for ownership review (Maggie)#13588
Open
kelmanchiang wants to merge 1 commit into
Open
Remove code review failure telemetry for ownership review (Maggie)#13588kelmanchiang wants to merge 1 commit into
kelmanchiang wants to merge 1 commit into
Conversation
Removes CodeReview.LoadDiffFailed and CodeReview.LoadMetadataFailed emissions and event definitions for code-review diff state paths. Co-Authored-By: Oz <oz-agent@warp.dev>
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
Contributor
There was a problem hiding this comment.
Overview
This PR removes the CodeReview.LoadDiffFailed and CodeReview.LoadMetadataFailed telemetry paths from local and remote diff-state models, deletes the associated operation/event metadata, and keeps existing error reporting/logging behavior in place.
Concerns
- 💡 [SUGGESTION]
app/src/code_review/telemetry_event.rsappears to keepuse std::time::Duration;after removing the onlyDuration-typed telemetry payload; remove that import to avoid an unused-import warning.
Verdict
Found: 0 critical, 0 important, 1 suggestions
Approve with nits
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Events covered in this PR
Validation
Co-Authored-By: Oz oz-agent@warp.dev