Skip to content

Remove code review failure telemetry for ownership review (Maggie)#13588

Open
kelmanchiang wants to merge 1 commit into
masterfrom
kc/remove-telemetry-maggie
Open

Remove code review failure telemetry for ownership review (Maggie)#13588
kelmanchiang wants to merge 1 commit into
masterfrom
kc/remove-telemetry-maggie

Conversation

@kelmanchiang

@kelmanchiang kelmanchiang commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • remove code review failure telemetry emissions in local and remote diff-state models
  • delete CodeReview.LoadDiffFailed and CodeReview.LoadMetadataFailed event variants and supporting metadata
  • keep code review diff behavior unchanged while removing these telemetry paths

Events covered in this PR

  • CodeReview.LoadDiffFailed
  • CodeReview.CalculateDiffMetadataFailed (mapped to CodeReview.LoadMetadataFailed)

Validation

  • ./script/format
  • cargo check --manifest-path app/Cargo.toml (fails in this environment: missing xcrun/metal)

Co-Authored-By: Oz oz-agent@warp.dev

Removes CodeReview.LoadDiffFailed and CodeReview.LoadMetadataFailed emissions and event definitions for code-review diff state paths.

Co-Authored-By: Oz <oz-agent@warp.dev>
@kelmanchiang kelmanchiang requested a review from MaggieShan July 10, 2026 20:43
@cla-bot cla-bot Bot added the cla-signed label Jul 10, 2026
@oz-for-oss

oz-for-oss Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

@kelmanchiang

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@oz-for-oss oz-for-oss Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR removes the CodeReview.LoadDiffFailed and CodeReview.LoadMetadataFailed telemetry paths from local and remote diff-state models, deletes the associated operation/event metadata, and keeps existing error reporting/logging behavior in place.

Concerns

  • 💡 [SUGGESTION] app/src/code_review/telemetry_event.rs appears to keep use std::time::Duration; after removing the only Duration-typed telemetry payload; remove that import to avoid an unused-import warning.

Verdict

Found: 0 critical, 0 important, 1 suggestions

Approve with nits

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant