[Feat] Scripts on events (#1070)#1196
Draft
pietervanleuven wants to merge 8 commits into
Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Delete events carry scalar primitives so the listener can reference them after the model row is gone. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- ExecuteScript::executeForHook() runs a script in hook context, injecting event variables and skipping user-auth validation - RunScriptEventHooks handles all 6 event types; failures are caught per-hook so they never surface to the originating action - AppServiceProvider registers the listener for all 6 events - GetBootstrap exposes event metadata to the frontend via configs() Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
16 tests covering CRUD, all 6 event types, disabled/cross-project skip, variable injection, and exception isolation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
6dce205 to
f602e70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1070
Attach an existing Script to a lifecycle event so it runs automatically whenever that event fires in a given project.
Events
site_domain,site_path,site_type,server_name,server_ipsite_domain,server_name,server_ipserver_name,server_ipserver_name,server_ipservice_name,service_type,service_version,server_name,server_ipservice_name,service_type,server_name,server_ipDesign notes
''(no prompt, no abort).Changes
ScriptEventHookmodel + migration + factoryCreateScriptEventHook/UpdateScriptEventHookactions (project write-access enforced)ScriptHookController+ScriptEventHookPolicy+ScriptEventHookResourceRunScriptEventHookslistener wired to all 6 events inAppServiceProviderExecuteScript::executeForHook()— transaction-wrapped, bypasses user authServerInstalledEvent,ServerDeletedEvent,ServiceInstalledEvent,ServiceUninstalledEventTesting
16 new feature tests covering CRUD, all 6 event types, disabled/cross-project skip, variable injection, and exception isolation.