-
Notifications
You must be signed in to change notification settings - Fork 208
NEXUS-484: Support UpdateWorkflow as a Nexus Operation #1631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mavemuri
wants to merge
2
commits into
main
Choose a base branch
from
mavemuri/update-nexus-op
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -138,6 +138,25 @@ class CancelWorkflowRunOptions: | |
| """The ID of the workflow to cancel.""" | ||
|
|
||
|
|
||
| @dataclass(frozen=True) | ||
| class CancelUpdateWorkflowOptions: | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing run ID |
||
| """Options for cancelling the workflow update backing a Nexus operation. | ||
|
|
||
| These options are built by :py:class:`TemporalOperationHandler` and passed to | ||
| :py:meth:`TemporalOperationHandler.cancel_workflow_update`. | ||
|
|
||
| .. warning:: | ||
| This API is experimental and unstable. | ||
| """ | ||
|
|
||
| workflow_id: str | ||
| """The ID of the workflow where the update is running.""" | ||
| update_id: str | ||
| """The ID of the update to cancel.""" | ||
| run_id: str | ||
| """The workflow runID that accepted the update""" | ||
|
|
||
|
|
||
| class TemporalOperationHandler(OperationHandler[InputT, OutputT], ABC): | ||
| """Operation handler for Nexus operations that interact with Temporal. | ||
| Implementations override the start_operation method. | ||
|
|
@@ -190,6 +209,15 @@ async def cancel(self, ctx: CancelOperationContext, token: str) -> None: | |
| workflow_id=operation_token.workflow_id | ||
| ) | ||
| await self.cancel_workflow_run(cancel_ctx, options) | ||
| case OperationTokenType.UPDATE_WORKFLOW: | ||
| assert operation_token.update_id is not None | ||
| assert operation_token.run_id is not None | ||
| cancel_options = CancelUpdateWorkflowOptions( | ||
| workflow_id=operation_token.workflow_id, | ||
| update_id=operation_token.update_id, | ||
| run_id=operation_token.run_id, | ||
| ) | ||
| await self.cancel_workflow_update(cancel_ctx, cancel_options) | ||
|
|
||
| async def cancel_workflow_run( | ||
| self, | ||
|
|
@@ -205,3 +233,23 @@ async def cancel_workflow_run( | |
| options.workflow_id | ||
| ) | ||
| await workflow_handle.cancel() | ||
|
|
||
| async def cancel_workflow_update( | ||
| self, | ||
| ctx: TemporalCancelOperationContext, # pyright: ignore[reportUnusedParameter] | ||
| options: CancelUpdateWorkflowOptions, # pyright: ignore[reportUnusedParameter] | ||
| ) -> None: | ||
| """Cancels the workflow update backing the Nexus operation. Cancellation is not natively supported for update-workflow Nexus operations. | ||
| Inherit a TemporalOperationHandler and override this method to run cancellable workflow updates. | ||
|
|
||
|
|
||
| .. warning:: | ||
| This API is experimental and unstable. | ||
| """ | ||
| raise HandlerError( | ||
| """ | ||
| Cancellation is not natively supported for update-workflow Nexus operations. | ||
| Inherit a TemporalOperationHandler and override this method to run cancellable workflow updates. | ||
| """, | ||
| type=HandlerErrorType.NOT_IMPLEMENTED, | ||
| ) | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of getting the workflow handle with just
workflow_idand then passingrun_idandfirst_execution_run_idtohandle._start_updatewe should get the handle with those IDs.Then in the details of
workflow_handle._start_updatewe can remove the new run_id and first_execution_run_id args and the checks for if they're set or not.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed this - will fix!