Skip to content

fix(emcn): remove brand-accent focus ring from TagInput default variant#5696

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/share-modal-green-outline
Jul 16, 2026
Merged

fix(emcn): remove brand-accent focus ring from TagInput default variant#5696
waleedlatif1 merged 1 commit into
stagingfrom
fix/share-modal-green-outline

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Remove the green --brand-accent focus ring from TagInput's default variant so it matches the canonical chip chrome — ChipInput shows no focus ring, and TagInput's block variant already omits it
  • Fixes the green outline on the "Allowed emails" field in the Share file modal (and any other default-variant TagInput)
  • Update the variant TSDoc since "no focus ring" is no longer a block-only differentiator

Type of Change

  • Bug fix

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Jul 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment Jul 15, 2026 8:16pm

Request Review

@cursor

cursor Bot commented Jul 15, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Pure focus styling and comment changes in one component; no logic, API, or accessibility behavior changes beyond removing a visual ring.

Overview
Removes the green --brand-accent focus ring from TagInput's default variant so focused fields (e.g. Share file modal “Allowed emails”) match ChipInput and the existing block variant, which already omit that ring.

The default variant still uses focus-within:outline-none; only the ring utilities are dropped. TSDoc for tagInputVariants is updated so “no focus ring” is documented for default as well, not only block.

Reviewed by Cursor Bugbot for commit 7bb1352. Configure here.

@greptile-apps

greptile-apps Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR aligns the default TagInput with the canonical chip-field styling. The main changes are:

  • Removes the brand-accent focus ring from the default variant.
  • Keeps focus represented by the text caret.
  • Updates the variant documentation to match the new behavior.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.
  • The styling now matches ChipInput, ChipTextarea, and the existing block variant.
  • The component API and runtime behavior are otherwise unchanged.

Important Files Changed

Filename Overview
packages/emcn/src/components/tag-input/tag-input.tsx Removes the default variant's focus ring and updates its documentation to match the established no-ring chip-field convention.

Reviews (1): Last reviewed commit: "fix(emcn): remove brand-accent focus rin..." | Re-trigger Greptile

@waleedlatif1 waleedlatif1 merged commit 58e4b75 into staging Jul 16, 2026
18 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/share-modal-green-outline branch July 16, 2026 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant