-
Notifications
You must be signed in to change notification settings - Fork 3.7k
fix(babysit): resolve merge conflicts against staging during the review loop #5695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+68
−50
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
f6f4c94
fix(babysit): resolve merge conflicts against staging during the revi…
TheodoreSpeaks daf4217
fix(babysit): trim merge-conflict handling to essentials
TheodoreSpeaks 62dde5b
fix(babysit): gate conflict-resolution pushes and handle UNKNOWN merg…
TheodoreSpeaks 3744df5
fix(babysit): bound persistent UNKNOWN mergeable state and clarify st…
TheodoreSpeaks f6aea3a
fix(babysit): merge instead of rebase to resolve conflicts, drop forc…
TheodoreSpeaks e3c5efe
fix(babysit): don't skip pending review findings when resolving a mer…
TheodoreSpeaks 435e14c
fix(babysit): spot-check commit hygiene before a merge-conflict push
TheodoreSpeaks 9d7612f
fix(babysit): commit merge-conflict fixes before pushing, bound UNKNO…
TheodoreSpeaks 4a46125
fix(babysit): run pre-push checks before committing the merge-conflic…
TheodoreSpeaks 4d758cd
fix(babysit): bound persistent CONFLICTING state and fix pre-push che…
TheodoreSpeaks 71648c7
fix(babysit): reconcile hard rule with step 2's merge-conflict sync e…
TheodoreSpeaks ff7474b
fix(babysit): page all review threads before branching on mergeable s…
TheodoreSpeaks 7232f30
fix(babysit): cut merge-conflict handling down to the essentials
TheodoreSpeaks a6216a0
fix(babysit): simplify merge-conflict handling to a minimal step
TheodoreSpeaks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.