Remove enableDirectEventsInEventTarget feature flag (#57528)#57528
Open
rubennorte wants to merge 2 commits into
Open
Remove enableDirectEventsInEventTarget feature flag (#57528)#57528rubennorte wants to merge 2 commits into
rubennorte wants to merge 2 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D111695476. |
meta-codesync
Bot
changed the title
rubennorte
force-pushed
the
export-D111695476
branch
from
793eaa4 to
6de1147
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 13, 2026
Summary: Cleans up the `enableDirectEventsInEventTarget` JS feature flag and inlines its usages as `true`. Direct events (those that neither bubble nor capture, such as `onLayout`) now always take the fast target-only dispatch path when EventTarget-based event dispatching is enabled, without a separate gate. - Removed the flag definition and regenerated the feature flags. - Inlined the flag in `dispatchNativeEvent` so `rnIsDirect` is derived directly from the event config. - Updated integration/benchmark tests: dropped the flag pragmas, made the fast-path test always run, and removed the now-dead legacy-path test. Changelog: [Internal] Differential Revision: D111695476
…react#57527) Summary: Add TODO comments to the `enableImperativeEvents` and `enableNativeEventTargetEventDispatching` feature flags explaining why they haven't progressed yet (the OSS renderer cannot be upgraded with the necessary changes until React 19.3.0 is released). This is a comment-only change with no functional impact. Changelog: [Internal] Reviewed By: huntie Differential Revision: D111695477
Summary: Cleans up the `enableDirectEventsInEventTarget` JS feature flag and inlines its usages as `true`. Direct events (those that neither bubble nor capture, such as `onLayout`) now always take the fast target-only dispatch path when EventTarget-based event dispatching is enabled, without a separate gate. - Removed the flag definition and regenerated the feature flags. - Inlined the flag in `dispatchNativeEvent` so `rnIsDirect` is derived directly from the event config. - Updated integration/benchmark tests: dropped the flag pragmas, made the fast-path test always run, and removed the now-dead legacy-path test. Changelog: [Internal] Reviewed By: huntie Differential Revision: D111695476
rubennorte
force-pushed
the
export-D111695476
branch
from
6de1147 to
382a7cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Cleans up the
enableDirectEventsInEventTargetJS feature flag and inlines its usages astrue. Direct events (those that neither bubble nor capture, such asonLayout) now always take the fast target-only dispatch path when EventTarget-based event dispatching is enabled, without a separate gate.dispatchNativeEventsornIsDirectis derived directly from the event config.Changelog:
[Internal]
Reviewed By: huntie
Differential Revision: D111695476