nvme-pci: DMA unmap the correct regions in nvme_free_sgls#7500
Merged
Conversation
[ commit a54afbc upstream ] The call to nvme_free_sgls() in nvme_unmap_data() has the sg_list and sge parameters swapped. This wasn't noticed by the compiler because both share the same type. On a Xen PV hardware domain, and possibly any other architectures that takes that path, this leads to corruption of the NVMe contents. Fixes: f0887e2 ("nvme-pci: create common sgl unmapping helper") Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> Signed-off-by: Keith Busch <kbusch@kernel.org>
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Jul 15, 2026
See: raspberrypi/linux#7500 kernel: staging: vchiq_arm: use one DMA device to map and unmap bulk pagelists See: raspberrypi/linux#7494 kernel: drm/vc4: hdmi: Remove duplicate hotplug helper call See: raspberrypi/linux#7489 kernel: ASoC: hifiberry_studio: change driver name and add support for new soundcards See: raspberrypi/linux#7487 kernel: mmc: Fix MMC request issuing race condition to prevent stall See: raspberrypi/linux#7486 kernel: dmaengine: dw-axi-dmac: Wait for runtime resume before using a channel See: raspberrypi/linux#7484 kernel: overlays: i2c-fan: add compatible for upstream compatibility See: raspberrypi/linux#7483
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Jul 15, 2026
See: raspberrypi/linux#7500 kernel: staging: vchiq_arm: use one DMA device to map and unmap bulk pagelists See: raspberrypi/linux#7494 kernel: drm/vc4: hdmi: Remove duplicate hotplug helper call See: raspberrypi/linux#7489 kernel: ASoC: hifiberry_studio: change driver name and add support for new soundcards See: raspberrypi/linux#7487 kernel: mmc: Fix MMC request issuing race condition to prevent stall See: raspberrypi/linux#7486 kernel: dmaengine: dw-axi-dmac: Wait for runtime resume before using a channel See: raspberrypi/linux#7484 kernel: overlays: i2c-fan: add compatible for upstream compatibility See: raspberrypi/linux#7483
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
N.B. I had to drop the
attrsparameter thatnvme_free_sglshas gained in the newer kernels. This presumably explains why it wasn't backported despite theFixes:tag (it's still disappointing, though).[ commit a54afbc upstream ]
The call to nvme_free_sgls() in nvme_unmap_data() has the sg_list and sge parameters swapped. This wasn't noticed by the compiler because both share the same type. On a Xen PV hardware domain, and possibly any other architectures that takes that path, this leads to corruption of the NVMe contents.
Fixes: f0887e2 ("nvme-pci: create common sgl unmapping helper")
Reviewed-by: Christoph Hellwig hch@lst.de