gh-153648: Deprecate http.client.HTTPMessage.getallmatchingheaders()#153649
Open
soreavis wants to merge 2 commits into
Open
gh-153648: Deprecate http.client.HTTPMessage.getallmatchingheaders()#153649soreavis wants to merge 2 commits into
soreavis wants to merge 2 commits into
Conversation
…ers() getallmatchingheaders() has returned an empty list for every input since Python 3.0 -- it compares keys() entries, which are bare header names, against "name:". Its only user was the CGI handler, removed in 3.15, and run_cgi() had already stopped calling it in 3.10. Deprecate it, with removal in 3.18. Use email.message.Message.get_all() instead.
Documentation build overview
7 files changed ·
|
picnixz
reviewed
Jul 13, 2026
picnixz
left a comment
picnixz
left a comment
Member
There was a problem hiding this comment.
Overall looks good but just a nit.
| """ | ||
| import warnings | ||
| warnings._deprecated( | ||
| "http.client.HTTPMessage.getallmatchingheaders", |
Member
There was a problem hiding this comment.
Can we have a "use XXX instead"?
Author
There was a problem hiding this comment.
Good call — done. The warning now reads:
'http.client.HTTPMessage.getallmatchingheaders' is deprecated and slated for removal in Python 3.18. Use email.message.Message.get_all() instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getallmatchingheaders()has returned an empty list for every input since Python 3.0 — it compareskeys()entries, which are bare header names, against"name:". Its only user was the CGI handler, which was removed in 3.15, andrun_cgi()had already stopped calling it in 3.10.Deprecate it, with removal in 3.18. That is PEP 387's minimum window rather than the usual five years, on the grounds that the method has never worked and has had no callers for five releases — happy to push it out to 3.21 if you'd rather keep it in line with the other 3.16 deprecations.
Use
email.message.Message.get_all()instead.#153648