[3.13] gh-128846: Fix test_configure_custom_copy for the aqua theme with Tk 9#153611
Open
serhiy-storchaka wants to merge 1 commit into
Open
[3.13] gh-128846: Fix test_configure_custom_copy for the aqua theme with Tk 9#153611serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
…heme with Tk 9 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
| # read back as an empty tuple rather than an empty string | ||
| # (see gh-128846); normalize before comparing. | ||
| def norm(value): | ||
| return '' if value == () else value |
Member
Author
There was a problem hiding this comment.
Suggested change
| return '' if value == () else value | |
| return () if value == '' else value |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS with the aqua theme and Tk 9, an empty ttk style option value is
read back as an empty tuple rather than an empty string, so
test_configure_custom_copyfailed when comparing a copied style against itsdefault. Normalize the empty tuple to an empty string before comparing.
Test-only; 3.13 lacks the
_tclobj_to_pynormalization that fixes this inthe library on 3.14+.