Skip to content

Fix fractional(0) returning "0/1" instead of "0" #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sreekant13 wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Open

Fix fractional(0) returning "0/1" instead of "0" #351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/humanize/number.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,9 +361,9 @@ def fractional(value: NumberOrString) -> str:
frac = Fraction(number - whole_number).limit_denominator(1000)
numerator = frac.numerator
denominator = frac.denominator
if whole_number and not numerator and denominator == 1:
if not numerator and denominator == 1:
# this means that an integer was passed in
# (or variants of that integer like 1.0000)
# (or variants of that integer like 1.0000, and including 0)
return f"{whole_number:.0f}"

if not whole_number:
Expand Down
2 changes: 2 additions & 0 deletions tests/test_number.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,8 @@ def test_apnumber(test_input: int | str, expected: str) -> None:
[
(1, "1"),
(2.0, "2"),
(0, "0"),
(0.0, "0"),
(4.0 / 3.0, "1 1/3"),
(5.0 / 6.0, "5/6"),
("7", "7"),
Expand Down