Add --distribution filter to container content list.#1443
Conversation
32a9791 to
0a58401
Compare
mdellweg
left a comment
mdellweg
left a comment
There was a problem hiding this comment.
You should rebase and probably squash the last two commits.
| if "/container-push/" in repository_href: | ||
| repo_ctx: PulpRepositoryContext = PulpContainerPushRepositoryContext( | ||
| pulp_ctx, pulp_href=repository_href | ||
| ) | ||
| else: | ||
| repo_ctx = PulpContainerRepositoryContext(pulp_ctx, pulp_href=repository_href) |
There was a problem hiding this comment.
The common base class wouldn't let us do this, right?
| if version is not None: | ||
| if distribution["repository"]: | ||
| distribution_ctx.update(body={"repository": ""}, non_blocking=non_blocking) | ||
| distribution_ctx.update(body={"repository": ""}, non_blocking=False) |
There was a problem hiding this comment.
Does the server still not allow to update these in one go?
There was a problem hiding this comment.
I believe it does, just my AI agent still struggling to test the code against my dev env and trying random stuff till CI passes.
Do we need the CLI to support pulpcore<3.24? I've removed the inbetween updates with the correct approach the API accepts.
There was a problem hiding this comment.
No, we strive to support what is a supported branch. And that means >= 3.49 atm.
There was a problem hiding this comment.
But we probably need to raise the guard in pulp_glue.common.context.PulpContext.__init__ before we just drop the one here.
There was a problem hiding this comment.
Should I bump it to 3.49 or to 3.24?
There was a problem hiding this comment.
I started to look what "cleanup" to 3.49 looks like.
#1445
It should be good to go with either 3.24 or 3.49 here. Just let's not make it false claims at any point.
| if not distribution: | ||
| return |
There was a problem hiding this comment.
How do you think about inverting the if here?
This currently looks like an if with only a disguised else branch.
3637f5b to
3f5786b
Compare
9241c73 to
dd6f418
Compare
Resolve the served repository version from a distribution so users can list tags and other content for an image without manual lookup steps. Co-authored-by: Cursor <cursoragent@cursor.com>
dd6f418 to
40d2a82
Compare
2 participants
Resolve the served repository version from a distribution so users can list tags and other content for an image without manual lookup steps.
Ref: pulp/pulp_container#2164