Skip to content

test: integration test for finalizer adding without SSA#3487

Open
csviri wants to merge 1 commit into
operator-framework:mainfrom
csviri:finalizer-no-ssa-it
Open

test: integration test for finalizer adding without SSA#3487
csviri wants to merge 1 commit into
operator-framework:mainfrom
csviri:finalizer-no-ssa-it

Conversation

@csviri

@csviri csviri commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator

Adds integration test for adding finalizer without Server Side Apply.

Signed-off-by: Attila Mészáros a_meszaros@apple.com

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Copilot AI review requested due to automatic review settings July 12, 2026 20:24
@openshift-ci openshift-ci Bot requested review from metacosm and xstefank July 12, 2026 20:24
@csviri csviri changed the title test: finalizer adding without ssa test: integration test for finalizer adding without SSA Jul 12, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a focused integration test in operator-framework to verify that the framework can add (and later remove) a reconciler finalizer when Server-Side Apply (SSA) is disabled for primary-resource patching.

Changes:

  • Introduces a new Cleaner-implementing reconciler used to exercise finalizer behavior with SSA disabled.
  • Adds an integration test that creates and deletes a custom resource, asserting finalizer addition and successful cleanup/deletion.
  • Adds a minimal custom resource type used exclusively by the new test.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/finalizernossa/AddFinalizerNoSSAReconciler.java New test reconciler implementing Cleaner to trigger framework-managed finalizer behavior without SSA.
operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/finalizernossa/AddFinalizerNoSSAIT.java New IT validating finalizer add/remove and cleanup path when SSA is disabled.
operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/finalizernossa/AddFinalizerNoSSACustomResource.java New minimal CR type used by the non-SSA finalizer integration test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants