Fix: Prevent mount conflicts and improve script stability with isolated scratch directories#623
Open
ducsum wants to merge 2 commits into
Open
Fix: Prevent mount conflicts and improve script stability with isolated scratch directories#623ducsum wants to merge 2 commits into
ducsum wants to merge 2 commits into
Conversation
Added Remove-ItemWithRetry to prevent infinite loops, separated scratchdir for install/boot WIMs to prevent mount errors, and added Cleanup-Mountpoints.
Updated the script path instructions in the README.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the stability and fault tolerance of
tiny11maker.ps1, specifically fixing "Access Denied" and DISM mount conflicts during the build process.Fixes & Improvements:
$ScratchDisk\scratchdirintoscratchdir_installandscratchdir_boot. This prevents fatal "Directory is not empty" errors ifinstall.wimunmount leaves lingering file locks behind.Remove-Itemwith a customRemove-ItemWithRetryfunction (retries with a delay and falls back tocmd rmdir). This stops the script from crashing during final cleanup due to Windows Defender locking files.dism /Cleanup-Mountpointsat startup to clear orphaned mounts from previous failed runs.autounattend.xmlat the end so users don't have to re-download it on every run.-SCRATCHparam documentation to indicate it accepts a<path>instead of just a<letter>.Note: Since
tiny11Coremaker.ps1shares the same logic, I highly recommend applying these isolated mount points and retry-cleanup changes there as well to prevent the same crashes.