feat(auth): bind DCR client credentials to issuing authorization server (SEP-2352)#998
Merged
Conversation
github-actions
Bot
added
T-core
DaleSeo
reviewed
Jul 16, 2026
| token_response: Some(token_result.clone()), | ||
| granted_scopes, | ||
| token_received_at: Some(Self::now_epoch_secs()), | ||
| issuer: self.metadata_issuer(), |
Member
There was a problem hiding this comment.
We now stamp issuer: self.metadata_issuer() here, but nothing reads it back. After a migration, what stops a static pre-registered credential from being silently sent to the new AS, the case where SEP-2352 says clients "SHOULD surface an error"?
Contributor
Author
There was a problem hiding this comment.
good catch. initialize_from_store now returns an AuthorizationServerMismatch error on issuer change
alexhancock
force-pushed
the
alexhancock/sep-2352-as-binding
branch
2 times, most recently
from
July 17, 2026 20:46
0c9c067 to
7696cf8
Compare
DaleSeo
reviewed
Jul 17, 2026
DaleSeo
previously approved these changes
Jul 17, 2026
alexhancock
force-pushed
the
alexhancock/sep-2352-as-binding
branch
from
July 18, 2026 00:45
d051669 to
6dac387
Compare
Contributor
Author
|
I applied your suggestion @DaleSeo but had to squash to satisfy commitlint. Can you re-stamp? TY! |
DaleSeo
approved these changes
Jul 18, 2026
This was referenced Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Per modelcontextprotocol/modelcontextprotocol#2352 clients SHOULD maintain separate registration state per auth server and MUST NOT assume cross-AS credential validity
How Has This Been Tested?
Conformance tests
Breaking Changes
None.
StoredCredentialsis #[non_exhaustive] and has anewconstructorTypes of changes
Checklist
Additional context
Closes #879