feat: complete azure-vm-starterkit BBD with child VM BBD, logo and e2e#225
Open
malhussan wants to merge 4 commits into
Open
feat: complete azure-vm-starterkit BBD with child VM BBD, logo and e2e#225malhussan wants to merge 4 commits into
malhussan wants to merge 4 commits into
Conversation
The azure-virtual-machine-starterkit shipped only the buildingblock/ implementation — it
never had a meshstack_integration.tf, so no building block definition (and no permissions
array / ephemeral run key) was ever wired up. Its buildingblock creates a meshProject, a
meshstack_tenant_v4 and a composed Azure VM child building block via provider "meshstack" {},
which needs the auto-injected ephemeral token that only a BBD permissions array grants.
Add the integration.tf modeled on the AKS/SKE starter kits (workspace-level permissions).
Reconstructed, never tested end-to-end — input assignment types (USER_INPUT vs STATIC),
the readme, and the composed azure_vm_definition_version_uuid wiring need author review.
Contributor
Scorecard Check
📊 meshstack-hub Module Scorecard
📋 Per-Module Category SummaryScore per category per building block.
Core Structure — ✅ all passingBasic module file structure and documentation — applies to 2 modules
Core Structure — Summary
Integration — ✅ all passingmeshstack_integration.tf conventions — applies to 2 modules
Integration — Summary
Azure Backplane — some checks failingAzure UAMI-based automation principal conventions — applies to 1 modules
Azure Backplane — Summary
STACKIT Backplane — not applicableSTACKIT WIF-based automation principal conventions — applies to 0 modules No applicable modules. Testing — some checks failingEnd-to-end test coverage — applies to 2 modules
Testing — Summary
📈 Overall SummaryOverall Average Score: 82%Score Distribution
|
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Adds the composed child azure-virtual-machine BBD, a starter-kit logo and an e2e test, and finishes the starter-kit BBD so it can be deployed and smoke-tested.
malhussan
force-pushed
the
feat/azure-vm-starterkit-complete
branch
from
July 16, 2026 07:54
eae1862 to
8ac91d5
Compare
meshStack has no optional-input concept, so the mutually-exclusive Linux/Windows credentials couldn't both be non-required. Drop Windows support (VM resources, os_type, admin_password) from the module and starter kit, leaving a required SSH key.
Enables the meshstack_building_block_v2 -> meshstack_building_block moved block: cross-type moves need OpenTofu >= 1.10 (1.9 errors "Resource type mismatch"), and the provider implements the move since v0.23.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the composed child azure-virtual-machine BBD, a starter-kit logo and an e2e test, and finishes the starter-kit BBD so it can be deployed and smoke-tested.