Try for IEEE754-precise poly2tri triangulation results#4500
Draft
roystgnr wants to merge 6 commits into
Draft
Conversation
This kills a little performance but makes it more robust to use the resulting meshes as "gold" results while using less safe optimization options elsewhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@loganharbour is experimenting with adding
CXXFLAGSfor Haswell architecture compiler optimizations, and the fused-multiply-add instructions there are (via rounding differently) changing MOOSEXYDelaunayoutputs. Compiling the whole thing with-ffp-contract=offfixes the problem, but we do want to allow fused-multiply-add in most of our code, so let's see if we can just disable non-IEEE754-compliant optimizations selectively.Leaving this marked as draft until Logan can verify that it works for him.