Kokkos cleanup#4499
Draft
roystgnr wants to merge 41 commits into
Draft
Conversation
roystgnr
marked this pull request as draft
July 17, 2026 17:51
This is a fraction of a commit authored by Rochi; I stripped off the m4 bits so we could just use the updated ACSM versions from the start.
With Kokkos we may have device compilers that can't handle them.
This is necessary for --enable-werror --enable-paranoid-warnings (and possibly just the former?) configurations with Ubuntu 26.4 Kokkos for me.
This looks like more of the sort of redundancy I want to get rid of, but I want to get compiling first.
I can't actually trigger this directly yet, but I needed it in MetaPhysicL for indirectly included Kokkos headers (at least for the version in Ubuntu 26.4) there.
This fixes --enable-werror --enable-paranoid-warnings --enable-kokkos builds for me.
"Should I add a layer of indirection to accomplish X" is one of the hardest questions in software, unless X is "nothing". Then it's easy.
This might become useful again depending on how we change things in the backend, but for now it's redundant with operator().
operator() setters here lets us avoid an indirection layer
If we had to support arbitrary third-party classes directly this would have been helpful, but we're writing our own shims here.
Hopefully this fixes the problem when Kokkos yells at us when we configure with OpenMP but then test its header (which we were doing without -fopenmp), as well as any problems downstream from people missing -fopenmp in pkgconfig.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accidentally hit "make pull request" when I was aiming for the arrow for "convert to draft".
Anyway, @rochi00 is seeing a weird Lapack LU failure in adaptivity_ex3 when running this branch himself, but I can't reproduce it, so I want to see what CI environments think.