Mesh preparation fixes#4435
Open
roystgnr wants to merge 5 commits into
Open
Conversation
roystgnr
added a commit
to roystgnr/moose
that referenced
this pull request
Apr 14, 2026
These ought to be fixed in libMesh/libmesh#4435, but I want more CI testing now!
roystgnr
added a commit
to roystgnr/moose
that referenced
this pull request
Apr 20, 2026
These ought to be fixed in libMesh/libmesh#4435, but I want more CI testing now!
roystgnr
added a commit
to roystgnr/moose
that referenced
this pull request
May 14, 2026
These ought to be fixed in libMesh/libmesh#4435, but I want more CI testing now!
roystgnr
force-pushed
the
mesh_preparation_fixes
branch
from
July 14, 2026 14:54
2becb65 to
773a311
Compare
GiudGiud
pushed a commit
to idaholab/moose
that referenced
this pull request
Jul 16, 2026
The existing code here isn't actually going to output wrong results (those Modification calls are invalidating cached spatial dimension but only querying cached subdomains), but it's interfering with my attempts to fix a couple libMesh preparation bugs in libMesh/libmesh#4435 Refs #32398
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm also testing these in #4411, but that's a huge branch, with the potential to trigger old downstream bugs, that I want to merge at just the most opportune time, whereas this branch has some pure fixes that will make it easier to avoid introducing new downstream bugs.