fix(server): queue thumbnail generation for hidden motion-photo companion videos#29847
fix(server): queue thumbnail generation for hidden motion-photo companion videos#29847tech00exploere wants to merge 1 commit into
Conversation
|
Label error. Requires exactly 1 of: changelog:.*. Found: 🗄️server. A maintainer will add the required label. |
|
The original path is not a video, nor a generated file. This also just tries to patch over another problem (some jobs that failed), and seems to break some existing branching. |
|
Thanks for the feedback. I see your point that using the original path as an encoded_video asset file breaks the intended semantics of that file type. I'll investigate why thumbnail generation expects an encoded video in this case and whether the correct fix is to fall back to the original media or address the earlier job that leaves the asset in this state. |
…deos - Remove the visibility skip check in handleGenerateThumbnails to allow thumbnail generation for hidden assets (like motion-photo companion videos). - Queue AssetGenerateThumbnails after handleVideoConversion completes, ensuring both transcoded and skip-transcode videos get their thumbnails generated.
9eaa2e5 to
0f63cb2
Compare
|
This PR has been automatically closed as the description doesn't follow our template. After you edit it to match the template, the PR will automatically be reopened. |
Description
When video conversion completed without requiring transcoding, hidden motion-photo companion videos never had thumbnail generation triggered. Since hidden assets are excluded from the batch thumbnail generation queue, the required preview and thumbnail files were never created, causing companion video thumbnail requests to return
Asset media not found.This change fixes the thumbnail generation flow by:
AssetGenerateThumbnailsafter video conversion completes, including when transcoding is skipped.EncodedVideoasset file for the original media, since thumbnail generation already operates directly on the original video.Fixes #29846
How Has This Been Tested?
EncodedVideoasset file is created when transcoding is skipped.Screenshots (if appropriate)
N/A
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)Please describe to which degree, if any, an LLM was used in creating this pull request.
An LLM was used to help analyze the existing codebase and discuss possible approaches. The implementation, debugging, testing, and final validation were completed manually.