fix(server): updated default CSP config to support videos from V3 player#29830
Open
l0ll098 wants to merge 1 commit into
Open
fix(server): updated default CSP config to support videos from V3 player#29830l0ll098 wants to merge 1 commit into
l0ll098 wants to merge 1 commit into
Conversation
Immich V3 added a new video player that had the side effect of breaking current CSP configuration on Chromium-based browsers. See issue 29441
|
Label error. Requires exactly 1 of: changelog:.*. Found: . A maintainer will add the required label. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Immich V3 added a new video player that had the side effect of breaking current CSP configuration on Chromium-based browsers, as also seen with issue #29441.
This PR addresses those issues by adding the missing CSP directive.
Fixes #29441
How Has This Been Tested?
IMMICH_HELMET_FILE.Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)Please describe to which degree, if any, an LLM was used in creating this pull request.
No LLMs were used.