fix(web): stop intercepting original assets in service worker#29823
Open
CatMe0w wants to merge 1 commit into
Open
fix(web): stop intercepting original assets in service worker#29823CatMe0w wants to merge 1 commit into
CatMe0w wants to merge 1 commit into
Conversation
|
Label error. Requires exactly 1 of: changelog:.*. Found: 🖥️web. A maintainer will add the required label. |
Member
|
The original there is probably in reference to viewing the original image rather than videos. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Default video playback uses the
/video/playbackendpoint, which already bypasses the service worker and allows the browser to use native byte-range requests.Enabling "Play original video" switches playback to the
/originalendpoint. This endpoint is currently intercepted and deduplicated by the service worker, causing affected original videos to be downloaded in full before playback. This is inconsistent with the existing default/video/playbackplayback behavior and should not be an expected approach of playing the original file.Limit service worker handling to thumbnail requests, matching its documented scope.
How Has This Been Tested?
206 Partial Contentresponses.Screenshots (if appropriate)
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)Please describe to which degree, if any, an LLM was used in creating this pull request.
An LLM was used to help set up a local dev environment. This change was manually written and tested.