feat(web): add wake lock when uploading assets#29820
Open
diogotcorreia wants to merge 1 commit into
Open
Conversation
This prevents a situation where the user, especially on mobile devices, has to keep tapping their screen to avoid the upload being interrupted.
|
Label error. Requires exactly 1 of: changelog:.*. Found: 🖥️web. A maintainer will add the required label. |
Member
|
We used to have this and deliberately removed it |
Contributor
Author
|
@bo0tzz I couldn't find any further discussion about this sadly, so I was not aware. The only wake lock discussions I found were related to the mobile apps. What was the reason for removal? I still believe this is a huge UX improvement for web users (i.e., when friends use a shared link), but feel free to close the PR if there are no plans to add this back. |
Member
|
Oh, I did somehow miss that this is for web and not mobile. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This prevents a situation where the user, especially on mobile devices, has to keep tapping their screen to avoid the upload being interrupted.
How Has This Been Tested?
I changed the screen timeout on my phone to the smallest allowed (15 seconds) and then started a big upload and checked that 15s had passed without the screen turning off.
Also attempted to switch tabs and leave the browser during the upload to test the
visibilitychangeevent listener.Additionally, used
console.logto check that the wakelock was being acquired/released at the correct times.Checklist:
I have made corresponding changes to the documentation if applicable(not applicable)I have confirmed that any new dependencies are strictly necessary.(no new dependencies)I have written tests for new code (if applicable)(don't think there's an easy way to write tests for this given the use of browser APIs)wakelock.svelte.jsshould be somewhere else)All code in(not applicable)src/services/uses repositories implementations for database calls, filesystem operations, etc.All code in(not applicable)src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)Please describe to which degree, if any, an LLM was used in creating this pull request.
No LLM