Skip to content

refactor(forges): read settings store inside the forge layer#3035

Open
afonsojramos wants to merge 2 commits into
mainfrom
refactor/forge-settings-store
Open

refactor(forges): read settings store inside the forge layer#3035
afonsojramos wants to merge 2 commits into
mainfrom
refactor/forge-settings-store

Conversation

@afonsojramos

Copy link
Copy Markdown
Member

Summary

Split from #3034. Pushes the settings-store boundary into the forge layer:

  • ForgeAdapter.listNotifications / enrichNotifications, both forge clients, and the notification-type handlers no longer thread a settings parameter through every call; they read useSettingsStore where the values are consumed.
  • The handlers' universally unused _settings parameter is removed.
  • Forge clients import the settings store leaf module directly (not the stores barrel), keeping the module graph free of a stores -> forges -> stores import cycle.
  • Forge tests seed the settings store instead of passing settings objects.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Refactoring of existing feature

Development

Successfully merging this pull request may close these issues.

1 participant