Skip to content

[review] feat: implement private-to-public-flows: allow as a tools.github frontmatter field#45129

Open
github-actions[bot] wants to merge 7 commits into
mainfrom
copilot/implement-private-to-public-flows-review-1783884427946
Open

[review] feat: implement private-to-public-flows: allow as a tools.github frontmatter field#45129
github-actions[bot] wants to merge 7 commits into
mainfrom
copilot/implement-private-to-public-flows-review-1783884427946

Conversation

@github-actions

@github-actions github-actions Bot commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Caution

agentic threat detected
Threat detection flagged this output in warn mode. Manual review is REQUIRED before any follow-up automation.

Reason: agent_failure

Review the workflow run logs for details.

This PR contains changes that were originally intended for PR #45113 (copilot/implement-private-to-public-flows).
Please review the changes carefully before merging.

Copilot AI and others added 6 commits July 12, 2026 17:01
Initial plan
0f0a899
@lpcox
feat: implement private-to-public-flows as tools.github frontmatter f…
92434fb 
…ield

- Add `private-to-public-flows` to the workflow frontmatter JSON schema
  under `tools.github`, accepting either `"allow"` (blanket opt-out) or
  an array of server ID strings (selective exemption)
- Add `PrivateToPublicFlows any` field to `GitHubToolConfig` struct
- Parse `private-to-public-flows` in `parseGitHubTool` (string and
  []string/[]any forms)
- Add `ForcePublicRepos *bool` and `SinkVisibilityExemptServers []string`
  to `MCPGatewayRuntimeConfig`
- In `buildMCPGatewayConfig`, translate `PrivateToPublicFlows` to the
  gateway config fields
- Emit `"forcePublicRepos": false` and `"sinkVisibilityExemptServers"`
  in the gateway JSON section of the renderer
- Reject `private-to-public-flows: allow` in strict mode (list form
  allowed per MCP Gateway Spec Section 10.9.4)
- Add documentation section to github-tools.md
- Add tests: parsing, gateway config building, emission, strict mode

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
@lpcox
feat: address code review - improve warning message clarity
95bc57e 
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
@github-actions
Merge branch 'main' into copilot/implement-private-to-public-flows
1ee1ba3
@lpcox
fix: address code review - propagate allow into sink-visibility, vali…
f5fcfe9 
…date server IDs, fix shell safety, update docs

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
@github-actions
Add changeset
c6f1b44
This was referenced Jul 12, 2026
Merged
Open
Base automatically changed from copilot/implement-private-to-public-flows to main July 12, 2026 20:01
@gh-aw-bot

gh-aw-bot commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator

@copilot please run the pr-finisher skill, review the PR state, and complete any remaining branch refresh or checks so maintainers can evaluate this follow-up PR quickly.

Generated by 👨‍🍳 PR Sous Chef · 18.8 AIC · ⌖ 7.66 AIC · ⊞ 4.2K · ◷
Comment /souschef to run again

@github-actions github-actions Bot mentioned this pull request Jul 12, 2026
Open
@gh-aw-bot
Merge origin/main into copilot branch
9dfcaa3 
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot AI commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

@copilot please run the pr-finisher skill, review the PR state, and complete any remaining branch refresh or checks so maintainers can evaluate this follow-up PR quickly.

...

Done. I ran PR finisher actions: refreshed the branch from main and resolved the merge conflict, then ran local validation (make fmt, make lint, make test-unit, make test, make recompile, and make agent-report-progress). The update is in commit 9dfcaa3; PR mergeability is now clean. CI on this new HEAD is still unverified until a maintainer re-triggers workflows.

Copilot AI requested a review from gh-aw-bot July 12, 2026 20:23
@gh-aw-bot

gh-aw-bot commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator

@copilot please run the pr-finisher skill, review the PR state, and rerun checks once the branch is ready for maintainer review.

Generated by PR Sous Chef run https://github.com/github/gh-aw/actions/runs/29207618338

Generated by 👨‍🍳 PR Sous Chef · 11.8 AIC · ⌖ 6.23 AIC · ⊞ 4.2K · ◷
Comment /souschef to run again

Copilot AI commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

@copilot please run the pr-finisher skill, review the PR state, and rerun checks once the branch is ready for maintainer review.

Generated by PR Sous Chef run https://github.com/github/gh-aw/acti...

Completed a second PR-finisher pass on current HEAD 9dfcaa3: PR is open/non-draft, mergeable clean, no unresolved review threads, and local checks rerun successfully (make fmt, make lint, make test-unit, make test, make recompile, make agent-report-progress). CI checks on this HEAD still need a maintainer-triggered rerun (workflow_dispatch, close/reopen, or maintainer push).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gh-aw-bot gh-aw-bot Awaiting requested review from gh-aw-bot

Assignees

No one assigned

Labels

needs-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gh-aw-bot