Skip to content

[jsweep] Clean write_daily_aic_usage_cache.cjs #45036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
github-actions wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −11
Draft

[jsweep] Clean write_daily_aic_usage_cache.cjs #45036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions actions/setup/js/write_daily_aic_usage_cache.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,15 +35,7 @@ const USAGE_DIR = "/tmp/gh-aw/usage";
* @param {Record<string, unknown>} [details]
*/
function logCache(message, details) {
let suffix = "";
if (details && Object.keys(details).length > 0) {
try {
suffix = ": " + JSON.stringify(details);
} catch (e) {
core.warning(`[daily-aic-cache] logCache: could not serialise details: ${e}`);
suffix = ": {}";
}
}
const suffix = details && Object.keys(details).length > 0 ? ": " + JSON.stringify(details) : "";
core.info(`[daily-aic-cache] ${message}${suffix}`);
}

Expand All @@ -58,8 +50,8 @@ function logCache(message, details) {
* @returns {Promise<void>}
*/
async function mainWithPaths(cacheFilePath, usageDir) {
const cachePath = cacheFilePath || CACHE_FILE_PATH;
const usageDirPath = usageDir || USAGE_DIR;
const cachePath = cacheFilePath ?? CACHE_FILE_PATH;
const usageDirPath = usageDir ?? USAGE_DIR;
try {
const runId = Number(process.env.GITHUB_RUN_ID || 0);
if (!runId) {
Expand Down
8 changes: 8 additions & 0 deletions actions/setup/js/write_daily_aic_usage_cache.test.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,14 @@ describe("write_daily_aic_usage_cache", () => {
expect(entry.aic).toBe(3.0);
});

it("writes a large AIC value correctly", async () => {
writeUsageFile(999.99);
await runMain();
const entry = JSON.parse(fs.readFileSync(cacheFile, "utf8").trim());
expect(entry.aic).toBe(999.99);
expect(global.core.warning).not.toHaveBeenCalled();
});

it("emits a warning and does not crash when the existing cache file cannot be read", async () => {
// Creating a directory at the cache path causes readFileSync to throw EISDIR
fs.mkdirSync(cacheFile);
Expand Down