Skip to content

Mark Antigravity as intentionally undocumented and gate engine-doc drift checks on that intent#45018

Open
pelikhan with Copilot wants to merge 4 commits into
mainfrom
copilot/doc-healer-stop-re-attempting-sync
Open

Mark Antigravity as intentionally undocumented and gate engine-doc drift checks on that intent#45018
pelikhan with Copilot wants to merge 4 commits into
mainfrom
copilot/doc-healer-stop-re-attempting-sync

Conversation

Copilot AI commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Doc-healer/DDUw repeatedly proposed the same antigravity docs/schema sync despite three maintainer rejections. This change records that exclusion in code and teaches drift-analysis workflows to treat it as intentional.

  • Engine intent model: explicit undocumented flag

    • Added undocumented bool to BaseEngine.
    • Added IsUndocumented() for runtime introspection.
    • Added EngineRegistry.GetDocumentedEngines() to return only engines that should participate in docs/schema parity checks.
  • Antigravity marked as intentionally excluded

    • Set undocumented: true in NewAntigravityEngine() so antigravity remains registered/usable but is not considered a docs/schema drift target.
  • Drift-detection workflow guidance updated

    • Updated schema-consistency-checker.md and deep-report.md instructions to skip docs/schema sync findings for engines explicitly marked undocumented.
    • Recompiled corresponding .lock.yml workflow artifacts.
  • Focused regression coverage

    • Added assertions that antigravity reports IsUndocumented() == true.
    • Added registry test coverage that GetDocumentedEngines() excludes antigravity and keeps documented engines (e.g. pi).
// pkg/workflow/antigravity_engine.go
BaseEngine: BaseEngine{
    id:            "antigravity",
    displayName:   "Antigravity CLI",
    experimental:  true,
    undocumented:  true,
}

Generated by 👨‍🍳 PR Sous Chef · 11.1 AIC · ⌖ 6.4 AIC · ⊞ 7.5K ·
Comment /souschef to run again

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix issue with rejected antigravity engine catalog sync Mark Antigravity as intentionally undocumented and gate engine-doc drift checks on that intent Jul 12, 2026
Copilot AI requested a review from pelikhan July 12, 2026 00:31
@github-actions

Copy link
Copy Markdown
Contributor

🤖 PR Triage

Field Value
Category refactor
Risk 🟡 Medium
Score 52/100 (Impact: 22, Urgency: 18, Quality: 12)
Action batch_review
Batch pr-batch:engine-refactor

Rationale: Adds undocumented flag to engine registry and gates doc-drift checks on it. Moderate risk — changes Go engine contracts. Candidate for batching with other engine-structure PRs. CI status: unknown (draft).

Generated by 🔧 PR Triage Agent · 148.7 AIC · ⌖ 4.43 AIC · ⊞ 5.6K ·

@github-actions

Copy link
Copy Markdown
Contributor

Great work here, @copilot-swe-agent! 🎉 This PR cleanly solves the recurring doc-healer false-positive problem by encoding the exclusion intent directly in code — a much more robust solution than comment-based workarounds.

The changes are well-scoped: IsUndocumented() / GetDocumentedEngines() on BaseEngine and EngineRegistry give the drift-detection workflows a first-class signal, the antigravity engine is correctly flagged, and the .md + .lock.yml workflow guidance is updated to match. Tests are included for the new logic. This looks ready for review.

Generated by ✅ Contribution Check · 84.2 AIC · ⌖ 11.2 AIC · ⊞ 6.2K ·

@github-actions

Copy link
Copy Markdown
Contributor

🤖 PR Triage

Field Value
Category refactor
Risk 🟢 low
Score 33/100 (impact:12 + urgency:12 + quality:9)
Action 📦 batch_review
Batch pr-batch:refactor-dedup (with #45044, #45045)

Rationale: Draft. Marks Antigravity as intentionally undocumented, preventing doc-healer from repeatedly reproposing rejected changes. Carry-over from prior run. Low risk, 8 files.

Triage run §29183606049

Generated by 🔧 PR Triage Agent · 171.6 AIC · ⌖ 5.63 AIC · ⊞ 5.6K ·

@pelikhan pelikhan marked this pull request as ready for review July 12, 2026 08:34
Copilot AI review requested due to automatic review settings July 12, 2026 08:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Marks Antigravity as intentionally undocumented and prevents automated drift workflows from proposing documentation/schema synchronization.

Changes:

  • Added engine-level documentation intent and registry filtering.
  • Marked Antigravity undocumented with regression coverage.
  • Updated and recompiled drift-analysis workflows.
Show a summary per file
File Description
pkg/workflow/antigravity_engine.go Marks Antigravity undocumented.
pkg/workflow/antigravity_engine_test.go Verifies Antigravity’s intent.
pkg/workflow/agentic_engine.go Adds introspection and documented-engine filtering.
pkg/workflow/agentic_engine_test.go Tests registry filtering.
.github/workflows/schema-consistency-checker.md Excludes intentionally undocumented engines.
.github/workflows/schema-consistency-checker.lock.yml Updates compiled workflow metadata.
.github/workflows/deep-report.md Suppresses intentional engine-doc drift tasks.
.github/workflows/deep-report.lock.yml Updates compiled workflow metadata.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 8/8 changed files
  • Comments generated: 0
  • Review effort level: Medium

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot please run the pr-finisher skill, address any unresolved review feedback, and rerun checks once the branch is up to date.

Run: https://github.com/github/gh-aw/actions/runs/29192100649

Generated by 👨‍🍳 PR Sous Chef · 7.72 AIC · ⌖ 5.14 AIC · ⊞ 4.2K ·
Comment /souschef to run again

# Conflicts:
#	.github/workflows/deep-report.lock.yml
#	.github/workflows/schema-consistency-checker.lock.yml

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

🤖 PR Triage

Field Value
Category refactor
Risk 🟡 Medium
Score 52/100 (impact: 22, urgency: 15, quality: 15)
Batch refactor-dedup (with #45045, #45044)
Action batch_review

Gates engine-doc drift checks on Antigravity intent flag. Small change (+42/-2). Review in batch.

Generated by 🔧 PR Triage Agent · 48.3 AIC · ⌖ 7.99 AIC · ⊞ 5.6K ·

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot AI commented Jul 12, 2026

Copy link
Copy Markdown
Contributor Author

@copilot please run the pr-finisher skill, address any unresolved review feedback, and rerun checks once the branch is up to date.

Run: https://github.com/github/gh-aw/actions/runs/29192100649...

Done. The branch was behind main due to a firewall-bump commit that regenerated all .lock.yml files — causing conflicts in deep-report.lock.yml and schema-consistency-checker.lock.yml. Resolved by merging main, then recompiling those two workflows from their .md sources to reapply our undocumented-engine guidance. All local checks pass (make fmt, make lint, make test-unit, make agent-report-progress). No unresolved review threads. Needs human CI re-trigger to go green.

Copilot AI requested a review from gh-aw-bot July 12, 2026 12:37
@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot please run the pr-finisher skill, address any unresolved review feedback, and rerun checks once the branch is up to date.

Run: https://github.com/github/gh-aw/actions/runs/29197331019

Generated by 👨‍🍳 PR Sous Chef · 11.1 AIC · ⌖ 6.4 AIC · ⊞ 7.5K ·
Comment /souschef to run again

Copilot AI commented Jul 12, 2026

Copy link
Copy Markdown
Contributor Author

@copilot please run the pr-finisher skill, address any unresolved review feedback, and rerun checks once the branch is up to date.

Run: https://github.com/github/gh-aw/actions/runs/29197331019...

Branch is up to date with main. Local validation passes (make fmt, make test-unit). No unresolved review threads. The only in-flight check is a copilot run that started after our last push — needs human CI re-trigger to confirm green.

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot please run the pr-finisher skill, address any unresolved review feedback, and rerun checks once the branch is up to date.

Run: https://github.com/github/gh-aw/actions/runs/29199165277

Generated by 👨‍🍳 PR Sous Chef · 4.72 AIC · ⌖ 4.27 AIC · ⊞ 4.2K ·
Comment /souschef to run again

Copilot AI commented Jul 12, 2026

Copy link
Copy Markdown
Contributor Author

@copilot please run the pr-finisher skill, address any unresolved review feedback, and rerun checks once the branch is up to date.

Run: https://github.com/github/gh-aw/actions/runs/29199165277...

Branch is up to date with main. PR Sous Chef run concluded success with no errors or failures. No unresolved review threads and no CI failures to fix. Ready for human approval and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[doc-healer] DDUw improvement: stop re-attempting the rejected antigravity engine catalog sync (3rd rejection: PR #44649)

4 participants