Formalize `replace-label` compliance model and fixture-backed conformance tests by Copilot · Pull Request #44981 · github/gh-aw

Copilot · 2026-07-11T15:53:15Z

This PR codifies the replace-label compliance fixtures as executable formal predicates and aligns the spec-facing compliance README with the generated Go test suite. It closes gaps between RL fixture semantics and in-repo conformance coverage by making the predicate/test mapping explicit.

Formal fixture execution for RL-001/002/003
- Added fixture-backed runners in pkg/workflow/replace_label_formal_test.go for:
  - rl-001-glob-semantics.yaml
  - rl-002-allowlist-enforcement.yaml
  - rl-003-blocklist-ordering.yaml
- Added fixture parsing guards (malformed YAML, empty scenarios).
Predicate-level conformance coverage (P1–P15 + edges)
- Added/expanded focused formal tests for:
  - required fields and length bounds (label_to_remove, label_to_add, repo)
  - count gate exclusivity (count < max, default max=5 behavior checks)
  - label-set arithmetic (remove/add semantics, dedup, missing-remove behavior)
  - staged semantics, blocklist symmetry, required-label/title-prefix gates
  - alias resolution (item_number / issue_number / pr_number / pull_number)
  - cross-repo restriction and exact-glob edge behavior
  - hard-error predicate modeling for REST failure outcomes.
Spec-compliance documentation alignment
- Updated specs/replace-label-compliance/README.md with:
  - formal model section
  - behavioral coverage map (predicate → test function)
  - generated test suite reference for in-process Go conformance.

func TestFormalGlobSemantics(t *testing.T) {
	runReplaceLabelFixture(t, "rl-001-glob-semantics.yaml")
}

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot

Pull request overview

Adds formal compliance coverage and documentation for replace-label behavior.

Changes:

Loads YAML compliance fixtures into Go tests.
Adds predicate and edge-case tests.
Documents the formal model and test mapping.

Show a summary per file

File	Description
`pkg/workflow/replace_label_formal_test.go`	Adds fixture loading and formal tests.
`specs/replace-label-compliance/README.md`	Documents predicates and coverage mapping.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 2/2 changed files
Comments generated: 5
Review effort level: Medium

gh-aw-bot · 2026-07-11T17:04:59Z

@copilot please run the pr-finisher skill, address the unresolved review feedback below, and rerun checks when done.

Unresolved review feedback to address:

Generated by 👨‍🍳 PR Sous Chef · 22.6 AIC · ⌖ 7.57 AIC · ⊞ 4.2K · ◷
_{Comment /souschef to run again}

…view feedback - formalMatchAnyPattern: replace path.Match with production-faithful regex (escapes brackets to literals, * spans any char) matching matchesSimpleGlob - rl-001 fixture: update char-class scenario to expect deny, reflecting that production implementation escapes brackets rather than treating them as character classes - replaceLabelExpected: add ErrorCode/*int and Reason/string fields decoded from fixture YAML - formalEvaluateFixtureScenario: return error instead of bool so callers can distinguish blocked-pattern from allowlist denial - runReplaceLabelFixture: switch on decision, fail on unknown values, assert error_code(-32003/-32002) ordering signal for deny scenarios - formalResolveItemNumberAliases: stop at first present alias (even non-positive) matching production temporary_id.cjs precedence behaviour - add formalRunReplaceLabel model + TestFormalStagedMode_NoWriteAPI to assert write API is not called in staged mode Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

… comment - Add source citation (escapeRegexChars in glob_pattern_helpers.cjs) to the escaped character list in formalSimpleGlobToRegex - Clarify formalResolveItemNumberAliases inline comment: first present alias returns 0 for non-positive without falling through Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot · 2026-07-11T17:24:38Z

@copilot please run the pr-finisher skill, address the unresolved review feedback below, and rerun checks when done.

Unresolved review feedback to address:...

All five review threads addressed in commits 9a66ac5 and f0b3dac:

Glob matcher aligned with production — formalMatchAnyPattern now uses formalSimpleGlobToRegex, a Go port of glob_pattern_helpers.cjs:simpleGlobToRegex (pathMode=false): brackets are escaped to literals, * expands to .*, matching is case-insensitive. The RL-001 char-class scenario updated to expect deny (production escapes brackets; the character-class scenario was a false green).
Blocklist ordering signal decoded — replaceLabelExpected now includes ErrorCode *int and Reason string decoded from fixture YAML. formalEvaluateFixtureScenario returns an error instead of bool. The fixture runner asserts error_code -32003 → error contains "blocked pattern" and -32002 → error contains "allowed list", letting TestFormalBlocklistOrdering verify ordering rather than just the binary allow/deny.
Unknown decision values fail the subtest — runReplaceLabelFixture now uses a switch on decision and calls t.Fatalf for any value that is not "allow" or "deny".
Staged mode write-API assertion — Added formalRunReplaceLabel(staged bool, onWrite func()) model function and TestFormalStagedMode_NoWriteAPI which asserts the onWrite counter stays at zero when staged=true. If the staged-mode branch were removed, the counter would reach 1 and the test would fail.
Alias resolution precedence — formalResolveItemNumberAliases now stops at the first present alias key even when the value is non-positive (returns 0 without falling through), matching temporary_id.cjs behaviour.

gh-aw-bot · 2026-07-11T17:36:09Z

pr-sous-chef
@copilot please run the pr-finisher skill, address the unresolved review feedback below, and rerun checks when done.

Unresolved review feedback to address:

copilot-pull-request-reviewer — align the compliance fixture matcher with production behavior or share one matcher
copilot-pull-request-reviewer — decode/assert error_code and reason so ordering is verifiable
copilot-pull-request-reviewer — fail on unknown fixture decision values
copilot-pull-request-reviewer — add a real staged-mode no-write assertion around the handler/write path
copilot-pull-request-reviewer — stop alias resolution after the first present alias, even when invalid

Run: https://github.com/github/gh-aw/actions/runs/29161645125

Generated by 👨‍🍳 PR Sous Chef · 6.92 AIC · ⌖ 7.23 AIC · ⊞ 4.2K · ◷
_{Comment /souschef to run again}

…Mode The direct struct construction in TestFormalStagedMode (lines 571-573) was flagged in review as not exercising the handler. The new TestFormalStagedMode_NoWriteAPI already asserts these properties via formalRunReplaceLabel, making the direct construction redundant. Remove it so TestFormalStagedMode focuses on config parsing and the write-API guard is tested by the dedicated test. Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

gh-aw-bot · 2026-07-12T01:02:56Z

@copilot please run the pr-finisher skill, address any unresolved review feedback, make sure the branch is up to date with the base branch, and rerun checks.

Generated by 👨‍🍳 PR Sous Chef · 9.19 AIC · ⌖ 8.12 AIC · ⊞ 7.5K · ◷
_{Comment /souschef to run again}

Copilot · 2026-07-12T01:06:45Z

@copilot please run the pr-finisher skill, address any unresolved review feedback, make sure the branch is up to date with the base branch, and rerun checks.

...

Branch is already up to date with main (merged in commit 40e8815). All 5 review threads remain resolved. CI run 29174674348 is currently in progress against HEAD. Nothing further is actionable for the agent.

gh-aw-bot · 2026-07-12T04:13:12Z

pr-sous-chef

@copilot please run the pr-finisher skill, address unresolved review comments, make sure the branch is up to date with the base branch, and rerun checks once complete.

Generated by 👨‍🍳 PR Sous Chef · 12.5 AIC · ⌖ 6.52 AIC · ⊞ 7.5K · ◷
_{Comment /souschef to run again}

…eplace-label-compliance Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot · 2026-07-12T04:21:38Z

pr-sous-chef

@copilot please run the pr-finisher skill, address unresolved review comments, make sure the branch is up to date with the base branch, and rerun checks once complete....

Branch merged up to date with main (commit 87da5a4, includes firewall bump v0.27.30). All 5 review threads remain resolved. Local make fmt and make test-unit pass. CI will need a human re-trigger against the new HEAD.

github-actions · 2026-07-12T07:16:58Z

🤖 PR Triage

Field	Value
Category	test
Risk	🟢 low
Score	47/100 (impact:20 + urgency:15 + quality:12)
Action	⚡ fast_track

Rationale: Non-draft, test-only additions formalizing replace-label compliance fixtures. Low risk, good description, no behavior changes. CI unknown — human review/approval likely quick.

Triage run §29183606049

Generated by 🔧 PR Triage Agent · 171.6 AIC · ⌖ 5.63 AIC · ⊞ 5.6K · ◷

gh-aw-bot · 2026-07-12T07:20:59Z

pr-sous-chef
@copilot please run the pr-finisher skill, confirm whether any unresolved review feedback remains, and if so address it and rerun checks once the branch is up to date. Run: https://github.com/github/gh-aw/actions/runs/29183870267

Generated by 👨‍🍳 PR Sous Chef · 9.89 AIC · ⌖ 6.64 AIC · ⊞ 6K · ◷
_{Comment /souschef to run again}

…eplace-label-compliance Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot · 2026-07-12T07:34:36Z

pr-sous-chef
@copilot please run the pr-finisher skill, confirm whether any unresolved review feedback remains, and if so address it and rerun checks once the branch is up to date. Run: https://gi...

Branch merged up to date with main (commit 8210608, includes safe-output fixture files and DICTATION update). All 5 review threads remain resolved. Local make fmt, make lint, make test-unit, and make agent-report-progress all pass. CI needs a human re-trigger against the new HEAD before merge.

github-actions · 2026-07-12T12:37:11Z

🤖 PR Triage

Field	Value
Category	`test`
Risk	🟢 Low
Score	65/100 (impact: 28, urgency: 20, quality: 17)
Action	`fast_track`

CI fully green ✅. Formalizes replace-label compliance model with fixture-backed tests. +418/-21. Low risk, high quality — fast track.

Generated by 🔧 PR Triage Agent · 48.3 AIC · ⌖ 7.99 AIC · ⊞ 5.6K · ◷

gh-aw-bot · 2026-07-12T12:48:25Z

@copilot please run the pr-finisher skill, address unresolved review feedback if any, and rerun checks once the branch is up to date.

Generated by 👨‍🍳 PR Sous Chef · 14.1 AIC · ⌖ 8.64 AIC · ⊞ 7.5K · ◷
_{Comment /souschef to run again}

…eplace-label-compliance Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot · 2026-07-12T12:58:19Z

@copilot please run the pr-finisher skill, address unresolved review feedback if any, and rerun checks once the branch is up to date.

...

Branch merged up to date with main (commit e1659c4, includes docs homepage updates). All 5 review threads remain resolved. Local make fmt, make test-unit, and make agent-report-progress all pass. CI needs a human re-trigger against the new HEAD before merge.

gh-aw-bot · 2026-07-12T14:44:12Z

@copilot please run the pr-finisher skill, address any unresolved review feedback, and rerun checks once the branch is up to date.

Run: https://github.com/github/gh-aw/actions/runs/29196572530

Generated by 👨‍🍳 PR Sous Chef · 8.11 AIC · ⌖ 5.41 AIC · ⊞ 4.2K · ◷
_{Comment /souschef to run again}

Copilot · 2026-07-12T14:49:04Z

@copilot please run the pr-finisher skill, address any unresolved review feedback, and rerun checks once the branch is up to date.

Run: https://github.com/github/gh-aw/actions/runs/29196572530...

Branch is already up to date with main (HEAD e1659c4). All 5 review threads remain resolved. No new review feedback to address. CI needs a human re-trigger before merge.

gh-aw-bot · 2026-07-12T16:34:03Z

@copilot please run the pr-finisher skill, address any unresolved review feedback, and rerun checks once the branch is up to date.

Run: https://github.com/github/gh-aw/actions/runs/29200137487

Generated by 👨‍🍳 PR Sous Chef · 8.57 AIC · ⌖ 7.74 AIC · ⊞ 7.5K · ◷
_{Comment /souschef to run again}

Copilot · 2026-07-12T16:37:49Z

@copilot please run the pr-finisher skill, address any unresolved review feedback, and rerun checks once the branch is up to date.

Run: https://github.com/github/gh-aw/actions/runs/29200137487...

Branch is already up to date with main (HEAD e1659c4). All 5 review threads remain resolved. No new review feedback to address. CI needs a human re-trigger before merge.

Initial plan

489382b

Copilot AI assigned Copilot and pelikhan Jul 11, 2026

Copilot started work on behalf of pelikhan July 11, 2026 15:53 View session

Copilot AI linked an issue Jul 11, 2026 that may be closed by this pull request

[formal-spec] replace-label-compliance/README.md — Formal model & test suite — 2026-07-11 #44980

Open

Copilot AI and others added 5 commits July 11, 2026 16:09

Add formal replace-label compliance mapping tests

718c711

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Address review feedback in formal replace-label docs/tests

5107159

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Tighten formal replace-label predicate test coverage

55aff9e

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Improve fixture loader semantics in formal replace-label tests

884eef6

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Harden formal replace-label fixture path and error predicates

5620903

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

pelikhan marked this pull request as ready for review July 11, 2026 16:32

Copilot AI review requested due to automatic review settings July 11, 2026 16:32

Copilot started reviewing on behalf of pelikhan July 11, 2026 16:32 View session

Address formal test review follow-ups

1dcb055

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Update README for replace-label compliance specification~~ Formalize replace-label compliance model and fixture-backed conformance tests Jul 11, 2026

Copilot finished work on behalf of pelikhan July 11, 2026 16:35

Copilot AI requested a review from pelikhan July 11, 2026 16:35

Copilot AI reviewed Jul 11, 2026

View reviewed changes

github-actions Bot mentioned this pull request Jul 11, 2026

[pr-sous-chef] Run report — 0 nudged, 0 skipped #44850

Closed

Copilot started work on behalf of gh-aw-bot July 11, 2026 17:05 View session

Copilot AI and others added 2 commits July 11, 2026 17:22

Copilot finished work on behalf of gh-aw-bot July 11, 2026 17:25

Copilot AI requested a review from gh-aw-bot July 11, 2026 17:25

Copilot started work on behalf of gh-aw-bot July 11, 2026 17:36 View session

Copilot finished work on behalf of gh-aw-bot July 11, 2026 17:52

Copilot started work on behalf of gh-aw-bot July 12, 2026 01:03 View session

Copilot finished work on behalf of gh-aw-bot July 12, 2026 01:07

Copilot started work on behalf of gh-aw-bot July 12, 2026 04:13 View session

Merge remote-tracking branch 'origin/main' into copilot/formal-spec-r…

87da5a4

…eplace-label-compliance Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot finished work on behalf of gh-aw-bot July 12, 2026 04:22

Copilot started work on behalf of gh-aw-bot July 12, 2026 07:21 View session

Merge remote-tracking branch 'origin/main' into copilot/formal-spec-r…

8210608

…eplace-label-compliance Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot finished work on behalf of gh-aw-bot July 12, 2026 07:34

github-actions Bot mentioned this pull request Jul 12, 2026

[PR Triage Report] PR Triage Report — 2026-07-12 (Run §29192671679) #45081

Open

Copilot started work on behalf of gh-aw-bot July 12, 2026 12:48 View session

Merge remote-tracking branch 'origin/main' into copilot/formal-spec-r…

e1659c4

…eplace-label-compliance Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot finished work on behalf of gh-aw-bot July 12, 2026 12:58

Copilot started work on behalf of gh-aw-bot July 12, 2026 14:44 View session

Copilot finished work on behalf of gh-aw-bot July 12, 2026 14:49

Copilot started work on behalf of gh-aw-bot July 12, 2026 16:34 View session

Copilot finished work on behalf of gh-aw-bot July 12, 2026 16:38

Uh oh!

Conversation

Copilot AI commented Jul 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gh-aw-bot commented Jul 11, 2026

Uh oh!

Copilot AI commented Jul 11, 2026

Uh oh!

gh-aw-bot commented Jul 11, 2026

Uh oh!

gh-aw-bot commented Jul 12, 2026

Uh oh!

Copilot AI commented Jul 12, 2026

Uh oh!

gh-aw-bot commented Jul 12, 2026

Uh oh!

Copilot AI commented Jul 12, 2026

Uh oh!

github-actions Bot commented Jul 12, 2026

🤖 PR Triage

Uh oh!

gh-aw-bot commented Jul 12, 2026

Uh oh!

Copilot AI commented Jul 12, 2026

Uh oh!

github-actions Bot commented Jul 12, 2026

🤖 PR Triage

Uh oh!

gh-aw-bot commented Jul 12, 2026

Uh oh!

Copilot AI commented Jul 12, 2026

Uh oh!

gh-aw-bot commented Jul 12, 2026

Uh oh!

Copilot AI commented Jul 12, 2026

Uh oh!

gh-aw-bot commented Jul 12, 2026

Uh oh!

Copilot AI commented Jul 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Jul 11, 2026 •

edited

Loading