Skip to content

fix: align debug logger variable names with logXxx convention#9198

Open
lpcox with Copilot wants to merge 2 commits into
mainfrom
copilot/duplicate-code-analysis-report
Open

fix: align debug logger variable names with logXxx convention#9198
lpcox with Copilot wants to merge 2 commits into
mainfrom
copilot/duplicate-code-analysis-report

Conversation

Copilot AI commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Three files used non-standard names (var log, var debugLog) and two packages each declared a var logHelpers — inconsistent with the logXxx convention in AGENTS.md and creating ambiguity when grepping.

Renames

Non-standard names → logXxx:

  • internal/auth/header.go: loglogAuth
  • internal/guard/context.go: loglogContext
  • internal/guard/registry.go: debugLoglogRegistry

Disambiguate duplicate logHelpers across packages:

  • internal/server/{http_helpers,middleware,sdk_logging}.go: logHelperslogServerHelpers
  • internal/mcp/helpers.go: logHelperslogMCPHelpers

Before/after:

// before
var log      = logger.New("auth:header")   // auth/header.go
var debugLog = logger.New("guard:registry") // guard/registry.go
var logHelpers = logger.New("server:helpers") // server/http_helpers.go
var logHelpers = logger.New("mcp:helpers")    // mcp/helpers.go

// after
var logAuth          = logger.New("auth:header")
var logRegistry      = logger.New("guard:registry")
var logServerHelpers = logger.New("server:helpers")
var logMCPHelpers    = logger.New("mcp:helpers")

All call sites updated; no behavioral changes.

Renames non-standard debug logger variables to follow the project's
logXxx naming convention defined in AGENTS.md:

- internal/auth/header.go: var log → var logAuth
- internal/guard/context.go: var log → var logContext
- internal/guard/registry.go: var debugLog → var logRegistry
- internal/server/{http_helpers,middleware,sdk_logging}.go: var logHelpers → var logServerHelpers
- internal/mcp/helpers.go: var logHelpers → var logMCPHelpers

Closes #9173, #9174, #9175
Copilot AI changed the title [WIP] Analyze and resolve duplicate code issues fix: align debug logger variable names with logXxx convention Jul 12, 2026
Copilot finished work on behalf of lpcox July 12, 2026 15:56
Copilot AI requested a review from lpcox July 12, 2026 15:56
@lpcox lpcox marked this pull request as ready for review July 12, 2026 20:02
Copilot AI review requested due to automatic review settings July 12, 2026 20:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns debug logger identifiers with the repository’s logXxx naming convention without behavioral changes.

Changes:

  • Renames ambiguous logger variables.
  • Updates all associated call sites.
  • Disambiguates helper loggers across packages.
Show a summary per file
File Description
internal/auth/header.go Renames the authentication logger.
internal/guard/context.go Renames the context logger.
internal/guard/registry.go Renames the registry logger.
internal/mcp/helpers.go Disambiguates the MCP helper logger.
internal/server/http_helpers.go Disambiguates the server helper logger.
internal/server/middleware.go Updates helper logger references.
internal/server/sdk_logging.go Updates the response logger reference.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 7/7 changed files
  • Comments generated: 0
  • Review effort level: Medium

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[duplicate-code] Duplicate Code Analysis Report — commit d600b1b

3 participants