docs(dotnet): Document RecordTransaction for already-completed transactions#18743
Open
jamescrosswell wants to merge 1 commit into
Open
docs(dotnet): Document RecordTransaction for already-completed transactions#18743jamescrosswell wants to merge 1 commit into
jamescrosswell wants to merge 1 commit into
Conversation
…ctions Adds a third section to the .NET custom instrumentation page covering the RecordTransaction API added in getsentry/sentry-dotnet#5333, which records transactions and spans that completed elsewhere (e.g. replayed through a proxy) with explicit timing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
jamescrosswell
marked this pull request as ready for review
July 17, 2026 03:02
| @@ -0,0 +1,40 @@ | |||
| ## Record Already-Completed Transactions | |||
|
|
|||
| <Alert> | |||
Contributor
There was a problem hiding this comment.
Bug: The documentation references version 6.8.0 for a new .NET SDK feature, but this version is tentative and unconfirmed. The feature may ship in a different release.
Severity: MEDIUM
Suggested Fix
Hold the merge of this pull request until the .NET SDK version containing the RecordTransaction feature is officially released. Once the version is confirmed, update the availableSince alert in the documentation to reflect the correct version number.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: platform-includes/performance/record-completed-transactions/dotnet.mdx#L3
Potential issue: The documentation for the new `RecordTransaction` feature in the .NET
SDK specifies it is available since version `6.8.0`. However, this version number is an
unconfirmed assumption, as noted in the pull request description. Publishing this
documentation before the SDK version is finalized could lead to users on version `6.8.0`
not finding the API if it ships later, or users on earlier versions encountering runtime
errors. This will likely cause user confusion and support tickets.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Documents the new
SentrySdk.RecordTransactionAPI from getsentry/sentry-dotnet#5333, which records transactions and spans that already completed elsewhere (e.g. work measured on another machine and replayed through a proxy) with explicit start timestamps and durations.platform-includes/performance/record-completed-transactions/dotnet.mdxinclude.StartTransaction: explicit timing, sampling skipped (BeforeSendTransactionstill runs), and clean-scope capture withConfigureScopefor attaching origin-trace data.Note: the version alert says
6.8.0— the SDK PR merged just after the6.7.0release cut, so this assumes it ships in the next release. Should be confirmed (and this PR held) until that release is out.IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
🤖 Generated with Claude Code