api: Use the public maven central relase of io.opencensus:opencensus-proto#237
Open
sfc-gh-pbennes wants to merge 1 commit into
Open
api: Use the public maven central relase of io.opencensus:opencensus-proto#237sfc-gh-pbennes wants to merge 1 commit into
sfc-gh-pbennes wants to merge 1 commit into
Conversation
This fixes an issue of duplicate and possibly incompatible classes for io.opencensus classes. If a project includes both opencensus-proto and api dependencies, there will be duplicate classes for opencensus-proto classes on the class path. This is because: - these classes are vendored in this repo but not declared in the pom - the version of opencensus-proto used is not a public release in maven central Fixes envoyproxy#171 Signed-off-by: Preston Bennes <preston.bennes@snowflake.com>
sfc-gh-pbennes
added a commit
to sfc-gh-pbennes/java-control-plane
that referenced
this pull request
May 13, 2022
…le-common-protos This fixes an issue of duplicate and possibly incompatible classes for com/google/api and com/google/rpc proto generated classes. If a project includes both api and proto-google-common-protos dependencies, there will be duplicate classes on the class path. This is because: - these classes are vendored in this repo but not declared in the pom - the version of proto-google-common-protos used is not a public release in maven central Similar to the issue in envoyproxy#171 that envoyproxy#237 will fix. Signed-off-by: Preston Bennes <preston.bennes@snowflake.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #237 +/- ##
============================================
- Coverage 82.48% 81.77% -0.72%
+ Complexity 275 274 -1
============================================
Files 31 31
Lines 982 982
Branches 78 78
============================================
- Hits 810 803 -7
- Misses 137 143 +6
- Partials 35 36 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue of duplicate and possibly incompatible classes for
io.opencensus classes. If a project includes both opencensus-proto and
api dependencies, there will be duplicate classes for opencensus-proto
classes on the class path. This is because:
Fixes #171
Signed-off-by: Preston Bennes preston.bennes@snowflake.com