Find/Replace overlay: assign control IDs at creation time#4191
Merged
HeikoKlare merged 1 commit intoJul 19, 2026
Merged
Conversation
Contributor
Currently, references to most controls of the FindReplaceOverlay are stored as fields of the class. Some are completely unused and others are only stored to later assign IDs to those controls (for testing). That ID assignment method was called from multiple places with an internal guard depending on the UI state (i.e., visibility of the replace bar) for not touching not-yet-created controls. This change inlines the assignment of IDs to the controls. This avoids the scattered calls of ID assignment and the guard, and lets the ToolItem fields that were only used for ID assignment become local variables.
HeikoKlare
force-pushed
the
findreplace-overlay-assign-ids-at-creation
branch
from
July 18, 2026 23:01
c35e6ce to
2c90d97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, references to most controls of the
FindReplaceOverlayare stored as fields of the class. Some are completely unused and others are only stored to later assign IDs to those controls (for testing). That ID assignment method was called from multiple places with an internal guard depending on the UI state (i.e., visibility of the replace bar) for not touching not-yet-created controls.This change inlines the assignment of IDs to the controls. This avoids the scattered calls of ID assignment and the guard, and lets the ToolItem fields that were only used for ID assignment become local variables.