Skip to content

Deprecate reuse-instance-id#1145

Merged
acroca merged 2 commits into
dapr:mainfrom
acroca:deprecate-reuse-instance-id
Jul 13, 2026
Merged

Deprecate reuse-instance-id#1145
acroca merged 2 commits into
dapr:mainfrom
acroca:deprecate-reuse-instance-id

Conversation

@acroca

@acroca acroca commented Jul 13, 2026

Copy link
Copy Markdown
Member

Description

Deprecates the reuse_id_policy argument on DaprWorkflowClient.schedule_new_workflow (sync and async).

Workflow instance IDs can always be reused once the existing instance has reached a terminal state (e.g. COMPLETED, FAILED, or TERMINATED), so the policy is unnecessary, and it currently has no effect anyway, since the underlying proto field is reserved and the policy is never sent on the wire.

The argument is kept for backward compatibility and will be removed in a future release.

@acroca acroca requested review from a team as code owners July 13, 2026 10:20
@acroca acroca self-assigned this Jul 13, 2026
Signed-off-by: Albert Callarisa <albert@diagrid.io>
@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.76%. Comparing base (be20bb5) to head (4ecb933).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1145      +/-   ##
==========================================
+ Coverage   82.75%   82.76%   +0.01%     
==========================================
  Files         123      123              
  Lines       10117    10123       +6     
==========================================
+ Hits         8372     8378       +6     
  Misses       1745     1745              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@acroca acroca force-pushed the deprecate-reuse-instance-id branch from 4a59a1a to def7d6f Compare July 13, 2026 10:23

@sicoyle sicoyle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thank you!

@sicoyle

sicoyle commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

@acroca to pls make an issue to roll this out or check this across the other sdks 🙏

@acroca acroca added this pull request to the merge queue Jul 13, 2026
Merged via the queue into dapr:main with commit bdd6f24 Jul 13, 2026
18 of 19 checks passed
acroca added a commit that referenced this pull request Jul 13, 2026
(cherry picked from commit bdd6f24)

Signed-off-by: Albert Callarisa <albert@diagrid.io>
Signed-off-by: dapr-bot <dapr-bot@users.noreply.github.com>
Co-authored-by: Albert Callarisa <albert@diagrid.io>
Co-authored-by: Sam <sam@diagrid.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants