[exec.let] Fix let-env argument in let-state env_t and constructor#9143
Merged
tkoeppe merged 1 commit intoJul 16, 2026
Merged
Conversation
In the let-state exposition-only class template, a misplaced closing parenthesis turned get_env(...) into a comma-operator operand instead of the second argument to let-env. As a result env_t collapsed to decltype(get_env(declval<Rcvr&>())), dropping the inner-sender environment overlay (completion scheduler/domain) carried by let-env, and the constructor's env initializer was inconsistent with that alias. Move the closing parenthesis so get_env(rcvr) is passed as let-env's second argument, matching the two-argument let-env defined earlier in [exec.let] and the env-t used by the check-types constraint. receiver2's get_env already composes env over get_env(rcvr), so storing the raw let-env result is sufficient.
eisenwave
added
the
P1-Important
Contributor
|
Presumably the missing parentheses just make the whole thing ill-formed... |
Contributor
|
I appreciate the dedication to the research, but just as some feedback: I don't think anyone would seriously have misunderstood this in the way your analysis considers. It was clearly just a simple oversight, and no analysis beyond "misapplication of the paper" is required here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix two
let-stateuses oflet-envmis-parenthesized while applying P3826R5 in #8919. The misapplication leftget_env(...)outsidelet-env(...), turning both uses into comma expressions.