[2026-06 LWG Motion 8] P3154R3 (Deprecating signed character types in iostreams)#9122
Merged
Merged
Conversation
notdanhan
force-pushed
the
motions-2026-06-lwg-8
branch
from
c395cda to
a2b2fd2
Compare
tkoeppe
force-pushed
the
motions-2026-06-lwg-8
branch
from
894eac8 to
a17bfe3
Compare
tkoeppe
reviewed
Jul 15, 2026
| @@ -6791,9 +6755,6 @@ | |||
| \tcode{basic_ostream<charT, traits>\&} | |||
| and the second is of type | |||
| \tcode{const char*}, | |||
Contributor
There was a problem hiding this comment.
This is missing the edit to fix up the previous item.
(I'll fix that.)
tkoeppe
force-pushed
the
motions-2026-06-lwg-8
branch
2 times, most recently
from
69a2158 to
622fe6b
Compare
tkoeppe
force-pushed
the
motions-2026-06-lwg-8
branch
from
622fe6b to
482b5c6
Compare
jwakely
reviewed
Jul 15, 2026
| \item | ||
| \tcode{traits::length(reinterpret_cast<const char*>(s))} | ||
| for the other two overloads. | ||
| \tcode{const char*}. |
Member
There was a problem hiding this comment.
This seems like an incredibly verbose way to say "for the first and third overloads" and "for the second overload". If we want to continue to refer to the parameter types not the ordering, we should at least talk about parameters not arguments!
And maybe the third overload should have been deprecated too, it will be redundant once the deprecated ones are gone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9095
Also Fixes cplusplus/papers#1804