Skip to content

fix(cli): accept matching --name and metadata.name in contract commands#3282

Merged
tknura merged 1 commit into
mainfrom
tknura/sol-58-wf-contract-update-name-conflict
Jul 13, 2026
Merged

fix(cli): accept matching --name and metadata.name in contract commands#3282
tknura merged 1 commit into
mainfrom
tknura/sol-58-wf-contract-update-name-conflict

Conversation

@tknura

@tknura tknura commented Jul 10, 2026

Copy link
Copy Markdown
Member

When both an explicit --name flag and metadata.name in the contract file were provided, workflow contract create/update/apply failed with conflicting names even when the two values were identical. This broke documented, copy-paste invocations.

This PR:

  • Accepts the command when --name and metadata.name are identical (the common, unambiguous case).
  • When they differ, emits an actionable error: --name "A" and metadata.name "B" differ: pass only one, or set them to the same value.
  • Adds unit tests for ValidateAndExtractName.
  • Aligns metadata.name in the SLSA/SSDF/CRA example contracts with the names used in the docs guides so the documented commands work as written (companion docs PR in platform-docs).

closes https://linear.app/chainloop/issue/sol-58

🤖 Generated with Claude Code

Review in cubic

When both an explicit --name flag and metadata.name in the contract
file were provided, the CLI rejected the command even if both values
were identical. Accept the command when they match and, when they
differ, emit an actionable error that tells the user how to resolve it.

Also align the metadata.name of the example contracts with the names
used in the SSDF, CRA and SLSA guides so the documented commands work
as written.

Fixes SOL-58

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: Tomasz Knura <tomasz.knura@itsilesia.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Re-trigger cubic

@tknura tknura merged commit 4a5d701 into main Jul 13, 2026
15 checks passed
@tknura tknura deleted the tknura/sol-58-wf-contract-update-name-conflict branch July 13, 2026 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants