fix(materials): do not record container image digest as tag#3281
Merged
Conversation
Signed-off-by: Tomasz Knura <tomasz.knura@itsilesia.com>
matiasinsaurralde
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a container image material was attested by digest (
image@sha256:...), the crafter recorded the digest string in the material'stagfield, sinceref.Identifier()returns the digest for digest references. The tag then surfaced through thechainloop.material.image.tagannotation and produced malformed pull-by-tag command hints (docker pull image:sha256:...) in the UI.The tag is now only populated when the reference is an actual tag reference; digest references record no tag. Untagged references still default to
latest.This also fixes tag extraction from the
io.containerd.image.nameannotation in the OCI layout path, which naively split the reference on:and mistook registry ports and digests for tags. The reference is now parsed withgo-containerregistry.closes https://linear.app/chainloop/issue/sol-68