Skip to content

fix(materials): do not record container image digest as tag#3281

Merged
tknura merged 1 commit into
mainfrom
tknura/sol-68-container-image-tag-digest
Jul 13, 2026
Merged

fix(materials): do not record container image digest as tag#3281
tknura merged 1 commit into
mainfrom
tknura/sol-68-container-image-tag-digest

Conversation

@tknura

@tknura tknura commented Jul 10, 2026

Copy link
Copy Markdown
Member

When a container image material was attested by digest (image@sha256:...), the crafter recorded the digest string in the material's tag field, since ref.Identifier() returns the digest for digest references. The tag then surfaced through the chainloop.material.image.tag annotation and produced malformed pull-by-tag command hints (docker pull image:sha256:...) in the UI.

The tag is now only populated when the reference is an actual tag reference; digest references record no tag. Untagged references still default to latest.

This also fixes tag extraction from the io.containerd.image.name annotation in the OCI layout path, which naively split the reference on : and mistook registry ports and digests for tags. The reference is now parsed with go-containerregistry.

closes https://linear.app/chainloop/issue/sol-68

Review in cubic

Signed-off-by: Tomasz Knura <tomasz.knura@itsilesia.com>
@tknura tknura requested a review from a team July 10, 2026 08:20

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Re-trigger cubic

@tknura tknura merged commit 780c6cb into main Jul 13, 2026
15 checks passed
@tknura tknura deleted the tknura/sol-68-container-image-tag-digest branch July 13, 2026 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants