Updated dependencies (master)#2340
Conversation
|
@cf-bottom Jenkins please :) |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14160/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14160/ |
|
@cf-bottom Jenkins please :) |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14165/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14165/ |
|
will rebase |
olehermanse
force-pushed
the
update-dependencies-action-master-1783929879
branch
from
0d4779f to
60f655b
Compare
Ticket: none Changelog: none
craigcomstock
force-pushed
the
update-dependencies-action-master-1783929879
branch
from
993418e to
f882a56
Compare
|
@cf-bottom jenkins please |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14174/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14174/ |
Adjusting core code to work with a dynamic max key size in lmdb is a larger effort. Ticket: ENT-14295 Changelog: none
|
@cf-bottom jenkins please |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14179/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14179/ |
Signed-off-by: Ihor Aleksandrychiev <ihor.aleksandrychiev@northern.tech>
|
@cf-bottom jenkins please |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14182/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14182/ |
|
windows only - |
|
PACKAGES_x86_64_mingw successfully built @cf-bottom please jenkins |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14194/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14194/ |
| From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 | ||
| From: Ihor Aleksandrychiev <igor.aleksandrychev@northern.tech> | ||
| Date: Tue, 14 Jul 2026 15:19:32 +0300 | ||
| Subject: [PATCH] Fix Windows/mingw LARGE_INTEGER usage in mdb.c |
There was a problem hiding this comment.
this should likely have an upstream bug number so we can track when to remove this patch.
There was a problem hiding this comment.
i looked at https://bugs.openldap.org/buglist.cgi?bug_status=__open__&content=windows&list_id=7358&order=Importance&query_format=specific (requires account I think) and didn't see any issues, but maybe there is one and maybe you need to create one.
There was a problem hiding this comment.
right, https://bugs.openldap.org/show_bug.cgi?id=10539#c1 in the next release should be fixed. added comment
|
|
||
| as_fn_error $? "Could not find pthreads library" "$LINENO" 5 | ||
|
|
||
| +fi |
There was a problem hiding this comment.
we should not be patching the configure script, but rather configure.ac and in this case Makefile.am where I recently added -ldl.
It's a bit of a mess as we add the autotools stuff and then in either patch 0005 or 0009 we add files like this configure which we should really NOT include, preferring to run autoconf/etc instead.
There was a problem hiding this comment.
good catch, moved the -ldl fix into the autotools source. 0012 now patches configure.ac and Makefile.am. 0013 carries the regenerated configure/Makefile.in, same split as 0009/0010.
lmdb 1.0.0 added incremental dump/load and MDB_RPAGE_CACHE remapping code that treats the Windows LARGE_INTEGER union as a scalar integer, which fails to compile with x86_64-w64-mingw32-gcc. Add a patch that accesses the .QuadPart member on Windows so offset arithmetic and SetFilePointerEx() use the correct type. POSIX builds are unaffected. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
lmdb 1.0.0's autotools source linked liblmdb (and, transitively, the tools) against -ldl unconditionally, via both liblmdb_la_LDFLAGS and AM_LDFLAGS in Makefile.am. libdl does not exist on Windows, so the mingw cross build failed with 'cannot find -ldl' when linking mdb_stat.exe. dlopen() is only used by module.c on Unix; Windows uses LoadLibrary(). Detect dlopen via AC_CHECK_LIB in configure.ac (adding -ldl to LIBS only when it links) and drop the hard-coded -ldl from Makefile.am. On Unix -ldl still flows into every link through $(LIBS); on Windows it is simply omitted. Split into a source patch (configure.ac, Makefile.am) and the regenerated files (configure, Makefile.in), matching the 0009/0010 split. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
aleksandrychev
force-pushed
the
update-dependencies-action-master-1783929879
branch
from
b4b906a to
679f7b5
Compare
5 participants
Automated dependency updates for the master branch
together: cfengine/core#6235