Skip to content

fix(serve): dedicated INFERENCE_RECOMMENDER telemetry feature + type workload param #6028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ZealSV wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(serve): dedicated INFERENCE_RECOMMENDER telemetry feature + type workload param #6028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sagemaker-core/src/sagemaker/core/telemetry/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ class Feature(Enum):
PROCESSING = 18
MODEL_CUSTOMIZATION_NOVA = 19
MODEL_CUSTOMIZATION_OSS = 20
INFERENCE_RECOMMENDER = 21

def __str__(self): # pylint: disable=E0307
"""Return the feature name."""
Expand Down
1 change: 1 addition & 0 deletions sagemaker-core/src/sagemaker/core/telemetry/telemetry_logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@
str(Feature.PROCESSING): 18,
str(Feature.MODEL_CUSTOMIZATION_NOVA): 19,
str(Feature.MODEL_CUSTOMIZATION_OSS): 20,
str(Feature.INFERENCE_RECOMMENDER): 21,
}

STATUS_TO_CODE = {
Expand Down
2 changes: 1 addition & 1 deletion sagemaker-serve/src/sagemaker/serve/ai_inference_recommender/_model_builder_methods.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ def _map_service_error(error: Exception) -> Exception:


@_telemetry_emitter(
feature=Feature.MODEL_CUSTOMIZATION, func_name="ai_inference_recommender.start_benchmark"
feature=Feature.INFERENCE_RECOMMENDER, func_name="ai_inference_recommender.start_benchmark"
)
def start_benchmark(
endpoint: Union[Endpoint, str],
Expand Down
4 changes: 2 additions & 2 deletions sagemaker-serve/src/sagemaker/serve/ai_inference_recommender/jobs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class BenchmarkJob(AIBenchmarkJob):
"""

@_telemetry_emitter(
feature=Feature.MODEL_CUSTOMIZATION, func_name="BenchmarkJob.show_result"
feature=Feature.INFERENCE_RECOMMENDER, func_name="BenchmarkJob.show_result"
)
def show_result(self):
"""Download the benchmark output from S3 and return a parsed result.
Expand All @@ -58,7 +58,7 @@ class RecommendationJob(AIRecommendationJob):
"""

@_telemetry_emitter(
feature=Feature.MODEL_CUSTOMIZATION, func_name="RecommendationJob.show_result"
feature=Feature.INFERENCE_RECOMMENDER, func_name="RecommendationJob.show_result"
)
def show_result(self) -> "_RecommendationsView":
"""Return the ranked recommendations produced by the job.
Expand Down
4 changes: 2 additions & 2 deletions sagemaker-serve/src/sagemaker/serve/model_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4427,12 +4427,12 @@ def _model_builder_optimize_wrapper(
return self.built_model

@_telemetry_emitter(
feature=Feature.MODEL_CUSTOMIZATION,
feature=Feature.INFERENCE_RECOMMENDER,
func_name="ModelBuilder.generate_deployment_recommendations",
)
def generate_deployment_recommendations(
self,
workload=None,
workload: Optional[Union["Workload", str]] = None,
performance_target: Optional[Union[str, "PerformanceTarget"]] = None,
*,
output_path: Optional[str] = None,
Expand Down
Loading