test(e2e): wait before archiving batch evaluation#1785
Open
notgitika wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
agentcore-harness-reviewing
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
Contributor
Package TarballHow to installgh release download pr-1785-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.24.1.tgz |
Contributor
Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the archive lifecycle E2E race exposed by full-suite run 29547583927.
agentcore run batch-evaluationreturns while the job is stillPENDINGunless--waitis provided. The test immediately attempted to archive that job, which intermittently failed with a service 409. Pass--waitso the evaluation reaches a terminal, archivable status first.The other two failures in that run were cascading assertions after the initial archive failed.
Related Issue
No issue; fixes a post-merge E2E failure.
Type of Change
Testing
npx tsc --noEmit --incrementalnpx prettier --check e2e-tests/archive-lifecycle.test.ts