Skip to content

fix(deploy): upgrade outdated CDK bootstrap stacks#1781

Merged
jariy17 merged 1 commit into
mainfrom
fix/659-outdated-bootstrap
Jul 17, 2026
Merged

fix(deploy): upgrade outdated CDK bootstrap stacks#1781
jariy17 merged 1 commit into
mainfrom
fix/659-outdated-bootstrap

Conversation

@notgitika

Copy link
Copy Markdown
Contributor

Summary

  • read the standard BootstrapVersion output from the CDKToolkit stack
  • treat bootstrap versions below 30, or legacy stacks without a version output, as requiring bootstrap
  • reuse the existing confirmation and --yes auto-bootstrap flow to upgrade outdated stacks before deploy
  • add regression coverage for version parsing and outdated-stack detection

Fixes #659

Testing

  • npx vitest run --project unit src/cli/cloudformation src/cli/operations/deploy (337 tests passed)
  • npm run typecheck
  • npx eslint src/cli/cloudformation/bootstrap.ts src/cli/operations/deploy/preflight.ts src/cli/cloudformation/__tests__/bootstrap-extended.test.ts src/cli/operations/deploy/__tests__/preflight-utils.test.ts
  • npx prettier --check src/cli/cloudformation/bootstrap.ts src/cli/operations/deploy/preflight.ts src/cli/cloudformation/__tests__/bootstrap-extended.test.ts src/cli/operations/deploy/__tests__/preflight-utils.test.ts
  • npm run build

@notgitika
notgitika requested a review from a team July 17, 2026 01:26
@github-actions github-actions Bot added the size/s PR size: S label Jul 17, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label Jul 17, 2026
@github-actions github-actions Bot added agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Jul 17, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Jul 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Package Tarball

aws-agentcore-0.24.1.tgz

How to install

gh release download pr-1781-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.24.1.tgz

@github-actions

Copy link
Copy Markdown
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 39.92% 14817 / 37108
🔵 Statements 39.18% 15791 / 40294
🔵 Functions 33.99% 2524 / 7424
🔵 Branches 33.43% 9875 / 29533
Generated in workflow #4129 for commit cdabd28 by the Vitest Coverage Report Action

@jariy17 jariy17 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, this should reduce a friction point for customers with old bootstraps.

@jariy17
jariy17 merged commit 5ab970b into main Jul 17, 2026
34 of 35 checks passed
@jariy17
jariy17 deleted the fix/659-outdated-bootstrap branch July 17, 2026 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s PR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle outdated CDK bootstrap version during deploy

2 participants