fix: show required marker on legacy select widgets#41927
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (5)
WalkthroughSelect, multi-select, and tree-select widgets now accept an optional ChangesRequired-state wiring for select widgets
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected. |
|
@miachillgood - this has been marked as stale as there are checks failed ❌ Failed checks (1 warning)Check name | Status | Explanation | Resolution -- | -- | -- | -- Docstring Coverage | |
Summary
isRequiredtoLabelWithTooltipfor the legacy select widgets covered by [Bug]: Required marker (*) not displayed on required select widgets #41734isRequiredprop throughSelectWidget,MultiSelectWidget,MultiSelectWidgetV2,SingleSelectTreeWidget, andMultiSelectTreeWidgetRoot cause
These widgets already expose and use
isRequiredfor validation, but the prop was not forwarded to the label component, so the required marker never rendered in the label UI.Testing
git diff --checkyarn eslintin this minimal checkout because the workspace does not include the local install state (Couldn't find the node_modules state file)Closes #41734
Summary by CodeRabbit
New Features
Bug Fixes