Skip to content

fix(templates): Make Camoufox template work with Playwright 1.61.0#2053

Open
Mantisus wants to merge 1 commit into
apify:masterfrom
Mantisus:fix-camoufox-template
Open

fix(templates): Make Camoufox template work with Playwright 1.61.0#2053
Mantisus wants to merge 1 commit into
apify:masterfrom
Mantisus:fix-camoufox-template

Conversation

@Mantisus

@Mantisus Mantisus commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

@Mantisus Mantisus self-assigned this Jul 9, 2026
Comment thread src/crawlee/project_template/templates/main_playwright_camoufox.py
@vdusek vdusek changed the title fix: Update playwright-camoufox template for playwright v1.61.0 fix(templates): Make Camoufox template work with Playwright 1.61.0 Jul 10, 2026

@vdusek vdusek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E tests seem to be still failing

@Pijukatel

Copy link
Copy Markdown
Collaborator

E2E tests seem to be still failing

Seems like something is wrong with the CLI setup unrelated to this change

@Pijukatel

Pijukatel commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

E2E tests seem to be still failing

Seems like something is wrong with the CLI setup unrelated to this change

Ok, it is because we do not supply the required token to PRs from the forked repo :-(

I have started the tests on a copy of Max's changes: https://github.com/apify/crawlee-python/actions/runs/29083049654

@Mantisus

Copy link
Copy Markdown
Collaborator Author

I have started the tests on a copy of Max's changes: https://github.com/apify/crawlee-python/actions/runs/29083049654

We need to release docker.io/apify/actor-python-playwright-camoufox:3.13-1.61.0 container

@vdusek

vdusek commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

I opened issue in apify/apify-actor-docker#297

@Pijukatel

Copy link
Copy Markdown
Collaborator

I have started the tests on a copy of Max's changes: https://github.com/apify/crawlee-python/actions/runs/29083049654

We need to release docker.io/apify/actor-python-playwright-camoufox:3.13-1.61.0 container

Seems like the release failed in test for the same reason as we are experiencing in Crawlee:
https://github.com/apify/apify-actor-docker/actions/runs/29143232736/job/86520178087

@Mantisus

Copy link
Copy Markdown
Collaborator Author

Seems like the release failed in test for the same reason as we are experiencing in Crawlee:
https://github.com/apify/apify-actor-docker/actions/runs/29143232736/job/86520178087

Am I correct in understanding that the Docker container tests deploy the Сrawlee template?
In other words, for a container test to pass, this PR must be released, but for this PR’s test to pass, a new container must be released. 🙂

@Pijukatel

Copy link
Copy Markdown
Collaborator

Seems like the release failed in test for the same reason as we are experiencing in Crawlee:
https://github.com/apify/apify-actor-docker/actions/runs/29143232736/job/86520178087

Am I correct in understanding that the Docker container tests deploy the Сrawlee template? In other words, for a container test to pass, this PR must be released, but for this PR’s test to pass, a new container must be released. 🙂

Haha, but no. Those tests are not running crawlee-based templates. It is some very simple test on Camoufox only:
https://github.com/apify/apify-actor-docker/blob/master/python-playwright-camoufox/src/main.py#L31

@Mantisus

Mantisus commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator Author

Haha, but no. Those tests are not running crawlee-based templates. It is some very simple test on Camoufox only:
https://github.com/apify/apify-actor-docker/blob/master/python-playwright-camoufox/src/main.py#L31

Thanks for the information. I'll make the PR with a fix.

UPD: apify/apify-actor-docker#299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate and fix Playwright 1.61.0 incompatibility with Camoufox

4 participants