[Tests] Update test_adaptive_pooling_window expected IR for const-int-bound fix#19995
Closed
sbinabdullah wants to merge 2 commits into
Closed
[Tests] Update test_adaptive_pooling_window expected IR for const-int-bound fix#19995sbinabdullah wants to merge 2 commits into
sbinabdullah wants to merge 2 commits into
Conversation
…-bound fix Followup to apache#19978: the const-int-bound modular-set fix correctly prevents the simplifier from over-folding the adaptive pool window extent. The previous expected IR used the simplified closed form (v_ax2 % 3 * 4 + 16) // 12 + 1, which was only reachable because the buggy bound let CanProve prove an invalid predicate. After the fix the generated IR retains the correct T.Select form, so update the expected IR to match and remove the xfail marker.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the test workload in test_te_create_primfunc.py by renaming a spatial block to adaptive_pool_sum_l1 and replacing the simplified grid range bounds and division factors with more precise T.Select expressions. There are no review comments, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Member
|
@tvm-bot rerun |
Contributor
|
Failed to re-run CI in https://github.com/apache/tvm/actions/runs/29456763618 Detailswith response |
tlopex
requested changes
Jul 17, 2026
tlopex
left a comment
tlopex
left a comment
Member
There was a problem hiding this comment.
Hi @sbinabdullah seems this branch predates the xfail added by #19978. Since the PR only changes lines inside the function, Git merges both changes without conflict and preserves the xfail. Could you rebase and remove it explicitly?
Contributor
Author
my bad. will do this. |
…-bound fixRemove xfail marker and update expected IR to match the T.Select form produced after the const-int-bound fix in apache#19978.
Contributor
Author
|
Closing to reopen with a fresh branch based on current main (the previous branch was based on an older fork main that predates the xfail from #19978, causing Git to preserve it during merge). Reopening as #20030. |
tlopex
pushed a commit
that referenced
this pull request
Jul 17, 2026
…-bound fix (#20023) Followup to #19978: the const-int-bound modular-set fix correctly prevents the simplifier from over-folding the adaptive pool window extent. The previous expected IR used the simplified closed form `(v_ax2 % 3 * 4 + 16) // 12 + 1`, which was only reachable because the buggy bound let `CanProve` prove an invalid predicate. After the fix the generated IR retains the correct `T.Select` form, so update the expected IR to match and remove the `xfail` marker that was added in #19978. This branch is based on current main so the `xfail` removal is explicit (addressing feedback from @tlopex on the previous attempt in #19995).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Followup to #19978 ([Arith] Fix const-int-bound modular-set tightening for Mod/FloorMod).
The const-int-bound fix correctly prevents the simplifier from over-folding the adaptive pool window extent expression. The previous expected IR in
test_adaptive_pooling_windowused the simplified closed form(v_ax2 % 3 * 4 + 16) // 12 + 1, which was only reachable because the buggy FloorMod bound letCanProvevalidate an invalid predicate. After the fix, the generated IR correctly retains theT.Selectform, so this PR updates the expected IR to match and removes thexfailmarker that was added in #19978.Changes
tests/python/te/test_te_create_primfunc.py: updated thetir_workloadintest_adaptive_pooling_windowto match the generated IR (loop extents and division now useT.Selectform; block nameadaptive_pool_sum_l1), and removed the@pytest.mark.xfaildecorator.Verification
xfail):test_te_create_primfunc.pysuite passes with no regressions.