Skip to content

RFC 7639 ALPN #731

Open
arturobernalg wants to merge 1 commit into
apache:masterfrom
arturobernalg:rfc7639
Open

RFC 7639 ALPN #731
arturobernalg wants to merge 1 commit into
apache:masterfrom
arturobernalg:rfc7639

Conversation

@arturobernalg

Copy link
Copy Markdown
Member

Add ConnectAlpnProvider and inject ALPN header in ConnectExec/AsyncConnectExec. Provide builder hooks for fixed list or provider-driven values.

@ok2c

ok2c commented Nov 29, 2025

Copy link
Copy Markdown
Member

@arturobernalg Could you please rebase this change-set?

@arturobernalg
arturobernalg force-pushed the rfc7639 branch 2 times, most recently from cc58cd1 to 208b565 Compare December 20, 2025 12:20
@arturobernalg

Copy link
Copy Markdown
Member Author

@arturobernalg Could you please rebase this change-set?

@ok2c done.

Comment thread httpclient5/src/main/java/org/apache/hc/client5/http/impl/AlpnHeaderSupport.java Outdated
Comment thread httpclient5/src/main/java/org/apache/hc/client5/http/impl/AlpnHeaderSupport.java Outdated
Comment thread httpclient5/src/main/java/org/apache/hc/client5/http/impl/AlpnHeaderSupport.java Outdated
Comment thread httpclient5/src/main/java/org/apache/hc/client5/http/impl/AlpnHeaderSupport.java Outdated
@arturobernalg
arturobernalg force-pushed the rfc7639 branch 2 times, most recently from a178fe7 to e343841 Compare January 12, 2026 09:57
@arturobernalg
arturobernalg requested a review from ok2c January 12, 2026 10:35
Comment thread httpclient5/src/main/java/org/apache/hc/client5/http/impl/AlpnHeaderSupport.java Outdated
Comment thread httpclient5/src/main/java/org/apache/hc/client5/http/impl/AlpnHeaderSupport.java Outdated
@ok2c

ok2c commented May 31, 2026

Copy link
Copy Markdown
Member

@arturobernalg This change can still make it into 5.7 if you are willing to invest time into it.

@arturobernalg
arturobernalg force-pushed the rfc7639 branch 2 times, most recently from 36079e1 to 46a533e Compare June 19, 2026 11:57
@arturobernalg
arturobernalg requested a review from ok2c June 19, 2026 12:12
@arturobernalg

Copy link
Copy Markdown
Member Author

@arturobernalg This change can still make it into 5.7 if you are willing to invest time into it.

@ok2c please do another pass

Comment thread httpclient5/src/main/java/org/apache/hc/client5/http/ConnectAlpnProvider.java Outdated
Encode protocol IDs with core's PercentCodec.HTTP_TOKEN (canonical RFC 7230 tchar form, uppercase hex) and decode strictly, rejecting malformed percent-encoding with ProtocolException. Configure via ConnectAlpnProvider through setConnectAlpnProvider on the classic and async builders; ConnectExec/AsyncConnectExec emit the header when a provider is set.

@ok2c ok2c left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arturobernalg Much, much better! However, we need to figure out a better of way of passing the actual TLS policy to the interceptors. I would try to solve it by adding HttpVersionPolicy as an attribute to HttpClientContext

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants