tools: Build docker image cloudstack-simulator#13597
Open
weizhouapache wants to merge 2 commits into
Open
Conversation
weizhouapache
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the CloudStack simulator Docker image build to modernize the base OS/toolchain and address build breakages when building the image in CI.
Changes:
- Upgrade base image to Ubuntu 24.04 and Java to OpenJDK 17.
- Upgrade Node.js installation to Node 24 (NodeSource setup script).
- Make Marvin tarball detection case-insensitive and simplify related build steps.
- Trigger the Docker image workflow on an additional branch.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tools/docker/Dockerfile | Updates OS/toolchain versions and tweaks Marvin + Node install steps for the simulator image build. |
| .github/workflows/docker-cloudstack-simulator.yml | Adds docker-image-build as an additional push branch trigger for the image build workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+65
to
+66
| MARVIN_FILE=`find /root/tools/marvin/dist/ -name "[mM]arvin*.tar.gz"`; \ | ||
| pip3 install $MARVIN_FILE --break-system-packages |
| pip3 install $MARVIN_FILE --break-system-packages | ||
|
|
||
| RUN curl -sL https://deb.nodesource.com/setup_14.x | sudo -E bash -; \ | ||
| RUN curl -sL https://deb.nodesource.com/setup_24.x | sudo -E bash -; \ |
| RUN curl -sL https://deb.nodesource.com/setup_14.x | sudo -E bash -; \ | ||
| RUN curl -sL https://deb.nodesource.com/setup_24.x | sudo -E bash -; \ | ||
| apt-get install -y nodejs; \ | ||
| cd ui && npm rebuild node-sass && npm install |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13597 +/- ##
======================================
Coverage 3.41% 3.41%
======================================
Files 486 486
Lines 41774 41774
Branches 7899 7899
======================================
Hits 1428 1428
Misses 40148 40148
Partials 198 198
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Comment on lines
+19
to
20
| command=/bin/bash -c "NODE_OPTIONS=--openssl-legacy-provider npm run serve" | ||
| directory=/root/ui |
Comment on lines
+37
to
+38
| openjdk-17-jre-headless \ | ||
| openjdk-17-jdk \ |
Comment on lines
+68
to
70
| RUN curl -sL https://deb.nodesource.com/setup_24.x | sudo -E bash -; \ | ||
| apt-get install -y nodejs; \ | ||
| cd ui && npm rebuild node-sass && npm install |
Comment on lines
20
to
27
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| - docker-image-build | ||
| tags: | ||
| - 4.* | ||
| - 5.* |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes docker image build errors
ubuntu 24.04instead of ubunutu 22.04Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?